From b26b54cc6f993309512f1a10733f17af49122d67 Mon Sep 17 00:00:00 2001 From: chrismo Date: Mon, 20 Jun 2016 01:25:07 -0500 Subject: GemVersionPromoter refactor UpdateOptions which was then renamed to DependencySearch is now called GemVersionPromoter, cuz I can't name this damn class. It's in its own file now, so there's that. I took a shot at moving Resolver#search_for into it, but had naively overlooked a few instance variables and such and it just didn't make as much sense as I'd first envisioned. Probably some other smaller classes in between perhaps. GemVersionPromoter class now caching its results, too, and I moved out the return from it back into Resolver as it made more sense there. As a standalone class, it may make sense to have this actually implement :major sorting, but maybe later. --- spec/resolver/basic_spec.rb | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'spec/resolver') diff --git a/spec/resolver/basic_spec.rb b/spec/resolver/basic_spec.rb index 99ffb429..41b9f8c8 100644 --- a/spec/resolver/basic_spec.rb +++ b/spec/resolver/basic_spec.rb @@ -178,12 +178,8 @@ describe "Resolving" do should_consv_resolve_and_include [:minor, :minimal], [], %w(foo-1.4.4 bar-2.0.4) end - it 'will not revert to a previous version' - - it 'has taken care of all MODOs' - - it 'has moved DependencySearch into its own file' - - it 'has moved search_for impl out of Resolver into DependencySearch' # method called by Molinillo, but bulk can go off to dep_search + it "will not revert to a previous version" + it "has taken care of all MODOs" + it "bring over all sort/filter specs from bundler-patch" end end -- cgit v1.2.3