aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBodo Möller <bodo@openssl.org>2000-12-06 21:33:58 +0000
committerBodo Möller <bodo@openssl.org>2000-12-06 21:33:58 +0000
commitaa66eba7c8c7496db92b80da19688d6f96a40b96 (patch)
treed375b6d9e1a2cc26496cd0222b67b01257416c82
parentf27b45d237a28a900e781f718804abe677091b08 (diff)
downloadopenssl-aa66eba7c8c7496db92b80da19688d6f96a40b96.tar.gz
BN_mod_sqrt documentation/comment
-rw-r--r--CHANGES4
-rw-r--r--crypto/bn/bn_sqrt.c2
2 files changed, 4 insertions, 2 deletions
diff --git a/CHANGES b/CHANGES
index ab334b87e1..9a1ad16fe3 100644
--- a/CHANGES
+++ b/CHANGES
@@ -32,7 +32,9 @@
[Richard Levitte]
*) New function BN_mod_sqrt for computing square roots modulo a prime
- (Tonelli-Shanks algorithm unless p == 3 (mod 4) or p == 5 (mod 8)).
+ (using the probabilistic Tonelli-Shanks algorithm unless
+ p == 3 (mod 4) or p == 5 (mod 8), which are cases that can
+ be handled deterministically).
[Lenka Fibikova <fibikova@exp-math.uni-essen.de>, Bodo Moeller]
*) Store verify_result within SSL_SESSION also for client side to
diff --git a/crypto/bn/bn_sqrt.c b/crypto/bn/bn_sqrt.c
index a54d9d2919..6d50b5d895 100644
--- a/crypto/bn/bn_sqrt.c
+++ b/crypto/bn/bn_sqrt.c
@@ -201,7 +201,7 @@ BIGNUM *BN_mod_sqrt(BIGNUM *in, const BIGNUM *a, const BIGNUM *p, BN_CTX *ctx)
/* t := (2*a)*b^2 - 1*/
if (!BN_mod_mul(t, t, y, p, ctx)) goto end;
- if (!BN_sub_word(t, 1)) goto end; /* cannot become negative */
+ if (!BN_sub_word(t, 1)) goto end;
/* x = a*b*t */
if (!BN_mod_mul(x, a, b, p, ctx)) goto end;