diff options
| author | Matt Caswell <matt@openssl.org> | 2016-04-15 14:45:12 +0100 |
|---|---|---|
| committer | Matt Caswell <matt@openssl.org> | 2016-04-21 10:51:57 +0100 |
| commit | dfefe7ec1e21078be4ad456c3f465cc174071d7c (patch) | |
| tree | 66b180fc8657402b69f3d52dba33c700e2e08628 | |
| parent | bcc31778e3695e23d7c4cd6274126a8e3d58db72 (diff) | |
| download | openssl-dfefe7ec1e21078be4ad456c3f465cc174071d7c.tar.gz | |
Fix a missing return value check in v3_addr
All other instances of extract_min_max are checked for an error return,
except this one.
Reviewed-by: Richard Levitte <levitte@openssl.org>
| -rw-r--r-- | crypto/x509v3/v3_addr.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/crypto/x509v3/v3_addr.c b/crypto/x509v3/v3_addr.c index 49d0d4d392..f68f937ffa 100644 --- a/crypto/x509v3/v3_addr.c +++ b/crypto/x509v3/v3_addr.c @@ -897,7 +897,8 @@ static int IPAddressOrRanges_canonize(IPAddressOrRanges *aors, IPAddressOrRange *a = sk_IPAddressOrRange_value(aors, j); if (a != NULL && a->type == IPAddressOrRange_addressRange) { unsigned char a_min[ADDR_RAW_BUF_LEN], a_max[ADDR_RAW_BUF_LEN]; - extract_min_max(a, a_min, a_max, length); + if (!extract_min_max(a, a_min, a_max, length)) + return 0; if (memcmp(a_min, a_max, length) > 0) return 0; } |