aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDr. Stephen Henson <steve@openssl.org>2007-10-04 12:07:52 +0000
committerDr. Stephen Henson <steve@openssl.org>2007-10-04 12:07:52 +0000
commit4f19a9cb9fa64f361d3e041f7772d8f4fc748efb (patch)
treeeaa873bd4806e5088a2c3cdba013e30024e3fd24
parent0023adb47a2cd543187dcee3a2effaa4207174ce (diff)
downloadopenssl-4f19a9cb9fa64f361d3e041f7772d8f4fc748efb.tar.gz
Off by one fix from stable branch.
-rw-r--r--ssl/ssl_lib.c22
1 files changed, 11 insertions, 11 deletions
diff --git a/ssl/ssl_lib.c b/ssl/ssl_lib.c
index c5d9f0e93e..9ed5ff2988 100644
--- a/ssl/ssl_lib.c
+++ b/ssl/ssl_lib.c
@@ -1277,7 +1277,6 @@ int SSL_set_cipher_list(SSL *s,const char *str)
char *SSL_get_shared_ciphers(const SSL *s,char *buf,int len)
{
char *p;
- const char *cp;
STACK_OF(SSL_CIPHER) *sk;
SSL_CIPHER *c;
int i;
@@ -1290,20 +1289,21 @@ char *SSL_get_shared_ciphers(const SSL *s,char *buf,int len)
sk=s->session->ciphers;
for (i=0; i<sk_SSL_CIPHER_num(sk); i++)
{
- /* Decrement for either the ':' or a '\0' */
- len--;
+ int n;
+
c=sk_SSL_CIPHER_value(sk,i);
- for (cp=c->name; *cp; )
+ n=strlen(c->name);
+ if (n+1 > len)
{
- if (len-- <= 0)
- {
- *p='\0';
- return(buf);
- }
- else
- *(p++)= *(cp++);
+ if (p != buf)
+ --p;
+ *p='\0';
+ return buf;
}
+ strcpy(p,c->name);
+ p+=n;
*(p++)=':';
+ len-=n+1;
}
p[-1]='\0';
return(buf);