diff options
| author | Benjamin Kaduk <bkaduk@akamai.com> | 2017-10-11 08:18:13 -0500 |
|---|---|---|
| committer | Benjamin Kaduk <bkaduk@akamai.com> | 2017-10-11 08:27:07 -0500 |
| commit | 165cc51f4ed3b2b84db7e3e00ee7134a1b2a3574 (patch) | |
| tree | 61d8dbf3f29be920583cbe087445a476dcb7f240 | |
| parent | f9df0a7775f483c175cda5832360cccd1db6943a (diff) | |
| download | openssl-165cc51f4ed3b2b84db7e3e00ee7134a1b2a3574.tar.gz | |
Appease -Werror=maybe-uninitialized
test/bad_dtls_test.c: In function 'validate_client_hello':
test/bad_dtls_test.c:128:33: error: 'u' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (!PACKET_get_1(&pkt, &u) || u != SSL3_RT_HANDSHAKE)
^
Apparently -O1 does not perform sufficient optimization to ascertain
that PACKET_get_1 will always initialize u if it returns true.
Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4518)
| -rw-r--r-- | test/bad_dtls_test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/bad_dtls_test.c b/test/bad_dtls_test.c index 7f6ffdc3ca..102de24464 100644 --- a/test/bad_dtls_test.c +++ b/test/bad_dtls_test.c @@ -118,7 +118,7 @@ static int validate_client_hello(BIO *wbio) long len; unsigned char *data; int cookie_found = 0; - unsigned int u; + unsigned int u = 0; len = BIO_get_mem_data(wbio, (char **)&data); if (!PACKET_buf_init(&pkt, data, len)) |