diff options
| author | Andy Polyakov <appro@openssl.org> | 2017-10-14 10:21:19 +0200 |
|---|---|---|
| committer | Andy Polyakov <appro@openssl.org> | 2017-10-17 21:36:31 +0200 |
| commit | 432f8688bb72e21939845ac7a69359ca718c6676 (patch) | |
| tree | 5faf3ecde311a038a5fb131e27d7290f932f61d8 | |
| parent | f5791af386b90d5e629687e23ba0681dd4070395 (diff) | |
| download | openssl-432f8688bb72e21939845ac7a69359ca718c6676.tar.gz | |
x509v3/v3_utl.c: avoid double-free.
Thanks to David Benjamin for spotting this.
Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4532)
| -rw-r--r-- | crypto/x509v3/v3_utl.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/x509v3/v3_utl.c b/crypto/x509v3/v3_utl.c index a839861dba..4dbcfaa430 100644 --- a/crypto/x509v3/v3_utl.c +++ b/crypto/x509v3/v3_utl.c @@ -56,8 +56,10 @@ int X509V3_add_value(const char *name, const char *value, return 1; err: X509V3err(X509V3_F_X509V3_ADD_VALUE, ERR_R_MALLOC_FAILURE); - if (sk_allocated) + if (sk_allocated) { sk_CONF_VALUE_free(*extlist); + *extlist = NULL; + } OPENSSL_free(vtmp); OPENSSL_free(tname); OPENSSL_free(tvalue); |