diff options
| author | Kurt Roeckx <kurt@roeckx.be> | 2016-11-11 21:41:50 +0100 |
|---|---|---|
| committer | Kurt Roeckx <kurt@roeckx.be> | 2016-11-12 14:07:31 +0100 |
| commit | e80f3b6af295133107ac709329eee16ccf9af61c (patch) | |
| tree | 2722bd4e846f71e7b8a1c21727239c860b2c8c62 | |
| parent | 866e505e0d663158b0fe63a7fb7455eebacc6470 (diff) | |
| download | openssl-e80f3b6af295133107ac709329eee16ccf9af61c.tar.gz | |
Cast to an unsigned type before negating
llvm's ubsan reported:
runtime error: negation of -9223372036854775808 cannot be represented in
type 'int64_t' (aka 'long'); cast to an unsigned type to negate this
value to itself
Found using libfuzzer
Reviewed-by: Rich Salz <rsalz@openssl.org>
GH: #1908
| -rw-r--r-- | crypto/asn1/a_int.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/asn1/a_int.c b/crypto/asn1/a_int.c index 36248df92d..833322e89b 100644 --- a/crypto/asn1/a_int.c +++ b/crypto/asn1/a_int.c @@ -289,7 +289,7 @@ static int asn1_get_int64(int64_t *pr, const unsigned char *b, size_t blen, ASN1err(ASN1_F_ASN1_GET_INT64, ASN1_R_TOO_SMALL); return 0; } - *pr = -(int64_t)r; + *pr = -(uint64_t)r; } else { if (r > INT64_MAX) { ASN1err(ASN1_F_ASN1_GET_INT64, ASN1_R_TOO_LARGE); |