diff options
| author | Richard Levitte <levitte@openssl.org> | 2016-02-14 13:02:15 +0100 |
|---|---|---|
| committer | Richard Levitte <levitte@openssl.org> | 2016-02-14 19:31:55 +0100 |
| commit | 18295f0c2db084fe00d935d8506d6e964f652d21 (patch) | |
| tree | 81e661fc1e2052c698b5daee8aae711e574bc0e4 /apps/ocsp.c | |
| parent | ef8ca6bd544e4baea67f9a193ae896b8629944d0 (diff) | |
| download | openssl-18295f0c2db084fe00d935d8506d6e964f652d21.tar.gz | |
Make sure to use unsigned char for is*() functions
On some platforms, the implementation is such that a signed char
triggers a warning when used with is*() functions. On others, the
behavior is outright buggy when presented with a char that happens
to get promoted to a negative integer.
The safest thing is to cast the char that's used to an unsigned char.
Reviewed-by: Andy Polyakov <appro@openssl.org>
Diffstat (limited to 'apps/ocsp.c')
| -rw-r--r-- | apps/ocsp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/ocsp.c b/apps/ocsp.c index 73b407c986..f9ba4e158a 100644 --- a/apps/ocsp.c +++ b/apps/ocsp.c @@ -1065,7 +1065,7 @@ static int urldecode(char *p) for (; *p; p++) { if (*p != '%') *out++ = *p; - else if (isxdigit(p[1]) && isxdigit(p[2])) { + else if (isxdigit(_UC(p[1])) && isxdigit(_UC(p[2]))) { *out++ = (app_hex(p[1]) << 4) | app_hex(p[2]); p += 2; } |