aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rename lots of *_intern or *_internal function to int_*Matt Caswell2016-04-1337-114/+114
| | | | | | | | There was a lot of naming inconsistency, so we try and standardise on one form. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Add a CHANGES entry for the deprecated cleanup functionsMatt Caswell2016-04-131-0/+11
| | | | | Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* make updateMatt Caswell2016-04-132-10/+10
| | | | | Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate CONF_modules_free() and make it a no-opMatt Caswell2016-04-136-15/+25
| | | | | | | | CONF_modules_free() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate ENGINE_cleanup() and make it a no-opMatt Caswell2016-04-137-30/+37
| | | | | | | | ENGINE_cleanup() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate OBJ_cleanup() and make it a no-opMatt Caswell2016-04-1313-20/+36
| | | | | | | | OBJ_cleanup() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate EVP_cleanup() and make it a no-opMatt Caswell2016-04-137-19/+48
| | | | | | | | EVP_cleanup() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate BIO_sock_cleanup() and make it a no-opMatt Caswell2016-04-134-6/+8
| | | | | | | | BIO_sock_cleanup() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate CRYPTO_cleanup_all_ex_data() and make it a no-opMatt Caswell2016-04-134-5/+7
| | | | | | | | CRYPTO_cleanup_all_ex_data() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate RAND_cleanup() and make it a no-opMatt Caswell2016-04-139-26/+38
| | | | | | | | RAND_cleanup() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Fix conditional compile logic in speed.cMatt Caswell2016-04-131-1/+1
| | | | | | | | The conditional compile logic wasn't quite right in speed.c for when both OPENSSL_NO_DSA and OPENSSL_NO_EC are defined. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate SSL_COMP_free_compression_methods() and make it a no-opMatt Caswell2016-04-135-11/+23
| | | | | | | | SSL_COMP_free_compression_methods() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate ERR_free_strings() and make it a no-opMatt Caswell2016-04-137-20/+35
| | | | | | | | ERR_free_strings() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Deprecate COMP_zlib_cleanup() and make it a no-opMatt Caswell2016-04-134-7/+21
| | | | | | | | COMP_zlib_cleanup() should not be called expicitly - we should leave auto-deinit to clean this up instead. Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org>
* X509_PUBKEY docsDr. Stephen Henson2016-04-133-9/+141
| | | | Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
* Fix setting of debug callback in apps/enc.cRichard Levitte2016-04-131-7/+11
| | | | | | | Setting the debug callback on the in and out BIOs were done too early. No debug callback was set on the zlib filter BIO. Reviewed-by: Tim Hudson <tjh@openssl.org>
* Add SSL_CTX_get_ciphers()Kazuki Yamaguchi2016-04-115-6/+22
| | | | | | | | | | | Add an accessor for SSL_CTX. Since libssl was made opaque, there is no way for users to access the cipher_list, while users can set the cipher_list by SSL_CTX_set_cipher_list(). Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org>
* Fix the no-posix-io optionMatt Caswell2016-04-111-1/+1
| | | | | | Fix a compile failure with no-posix-io Reviewed-by: Tim Hudson <tjh@openssl.org>
* Remove an unused functionMatt Caswell2016-04-112-15/+0
| | | | | | | | The function pqueue_print is not exported and is never called. Therefore we should delete it. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org>
* Fix the no-tls optionMatt Caswell2016-04-111-15/+18
| | | | | | The no-tls option was failing in the tests. This fixes it. Reviewed-by: Richard Levitte <levitte@openssl.org>
* Fix the no-nextprotoneg optionMatt Caswell2016-04-114-0/+10
| | | | | | Misc fixes to get no-nextprotoneg config option working again. Reviewed-by: Rich Salz <rsalz@openssl.org>
* BIO: respect opening in text modeRichard Levitte2016-04-111-1/+5
| | | | | | | When a file is opened with BIO_new_file(), make sure that the internal mode TEXT vs BINARY setting reflects what's given in the mode string. Reviewed-by: Andy Polyakov <appro@openssl.org>
* Disable some sanitizer checks without PEDANTICEmilia Kasper2016-04-102-5/+3
| | | | | | | | | | | | | | | | | | Code without PEDANTIC has intentional "undefined" behaviour. To get best coverage for both PEDANTIC and non-PEDANTIC codepaths, run the sanitizer builds in two different configurations: 1) Without PEDANTIC but with alignment checks disabled. 2) With PEDANTIC. To not overload Travis too much, run one build with clang and the other with gcc (chosen at random). Also remove a micro-optimization in CAST code to be able to -fsanitize=shift. Whether shift sanitization is meaningful for crypto or an obstacle is debatable but since this appears to be the only offender, we might as well keep the check for now. Reviewed-by: Richard Levitte <levitte@openssl.org>
* Fix warnings exposed by clang-3.8Emilia Kasper2016-04-102-4/+7
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* Adjust --strict-warnings builds in TravisEmilia Kasper2016-04-102-6/+11
| | | | | | | | In Travis, do --strict-warnings on BUILDONLY configurations. This ensures that the tests run even if --strict-warnings fail, and avoids hiding unrelated test failures. Reviewed-by: Richard Levitte <levitte@openssl.org>
* Don't check the generated ssl-tests configs on VMSRichard Levitte2016-04-091-1/+2
| | | | | | | The simple reason is that the pre-generated files are mainly for Unix. The VMS variants look slightly different, so comparing will always fail. Reviewed-by: Emilia Käsper <emilia@openssl.org>
* VMS doesn't have directory separators in the same sense as UnixRichard Levitte2016-04-091-3/+5
| | | | | | | Don't add / in file specs on VMS. The directory "separator" is part of the directory spec. Reviewed-by: Emilia Käsper <emilia@openssl.org>
* RSA: the docs still talk about RSA_PKCS1_SSLeayBeat Bolli2016-04-091-4/+4
| | | | | | | Rename the function to RSA_PKCS1_OpenSSL. Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org>
* Add CHANGES entry for DH and DH_METHOD opacityMatt Caswell2016-04-091-0/+5
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* Add documentation for following DH and DH_METHOD opacityMatt Caswell2016-04-095-45/+249
| | | | | | | A number of new functions have been added following the DH and DH_METHOD opacity commits. This commit provides documentation for those functions. Reviewed-by: Richard Levitte <levitte@openssl.org>
* Fix double free bug in error pathMatt Caswell2016-04-091-0/+1
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* make updateMatt Caswell2016-04-091-0/+21
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* Make DH_METHOD opaqueMatt Caswell2016-04-095-21/+209
| | | | | | | Move the dh_method structure into an internal header file and provide relevant accessors for the internal fields. Reviewed-by: Richard Levitte <levitte@openssl.org>
* make updateMatt Caswell2016-04-091-0/+10
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* Make DH opaqueMatt Caswell2016-04-0918-115/+305
| | | | | | | Move the dh_st structure into an internal header file and provide relevant accessors for the internal fields. Reviewed-by: Richard Levitte <levitte@openssl.org>
* Add SSL_DANE typedef for consistency.Rich Salz2016-04-087-22/+23
| | | | Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
* Add OCSP to mkdefRich Salz2016-04-081-0/+1
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* PPC assembly pack: remove branch hints.Andy Polyakov2016-04-076-25/+25
| | | | | | | | | | As it turns out branch hints grew as kind of a misconception. In addition their interpretation by GNU assembler is affected by assembler flags and can end up with opposite meaning on different processors. As we have to loose quite a lot on misinterprerations, especially on newer processors, we just omit them altogether. Reviewed-by: Tim Hudson <tjh@openssl.org>
* Clean-up *_DEBUG options.Andy Polyakov2016-04-0713-69/+21
| | | | | | | | | Since NDEBUG is defined unconditionally on command line for release builds, we can omit *_DEBUG options in favour of effective "all-on" in debug builds exercised though CI. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Emilia Käsper <emilia@openssl.org>
* Configurations/10-main.conf: omit now redundant -D_WINDLL.Andy Polyakov2016-04-071-7/+19
| | | | | | ... and refine /MT vs. /MD flag handling. Reviewed-by: Richard Levitte <levitte@openssl.org>
* windows-makefile.tmpl: clean up after DLL link failure.Andy Polyakov2016-04-071-1/+1
| | | | | | | | | Without proper cleanup after DLL link failure second attempt to run nmake would actually proceed and failure will be "shifted" to run time. This is because libcrypto.lib import library is generated even if DLL link fails. Reviewed-by: Richard Levitte <levitte@openssl.org>
* test/[dane|evp_]test.c: BIO-fy file I/O.Andy Polyakov2016-04-072-19/+19
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* bio/bss_file.c: since VS2015 one can't tell apart own and "alien" FILEAndy Polyakov2016-04-071-2/+5
| | | | | | pointers, except for minimal std[in|out|err]. Reviewed-by: Richard Levitte <levitte@openssl.org>
* make updateViktor Dukhovni2016-04-076-17/+18
| | | | | Signed-off-by: Rob Percival <robpercival@google.com> Reviewed-by: Emilia Käsper <emilia@openssl.org>
* Suppress CT callback as appropriateViktor Dukhovni2016-04-0717-237/+382
| | | | | | | | | | | | | | | | | | | | | | Suppress CT callbacks with aNULL or PSK ciphersuites that involve no certificates. Ditto when the certificate chain is validated via DANE-TA(2) or DANE-EE(3) TLSA records. Also skip SCT processing when the chain is fails verification. Move and consolidate CT callbacks from libcrypto to libssl. We also simplify the interface to SSL_{,CTX_}_enable_ct() which can specify either a permissive mode that just collects information or a strict mode that requires at least one valid SCT or else asks to abort the connection. Simplified SCT processing and options in s_client(1) which now has just a simple pair of "-noct" vs. "-ct" options, the latter enables the permissive callback so that we can complete the handshake and report all relevant information. When printing SCTs, print the validation status if set and not valid. Signed-off-by: Rob Percival <robpercival@google.com> Reviewed-by: Emilia Käsper <emilia@openssl.org>
* Fix client verify mode to check SSL_VERIFY_PEERViktor Dukhovni2016-04-072-15/+2
| | | | | | | | | | The original check for != SSL_VERIFY_NONE can give surprising results when flags SSL_VERIFY_PEER is not set, but other flags are. Note that SSL_VERIFY_NONE (0) is not a flag bit, it is rather the absense of all other flag bits. Signed-off-by: Rob Percival <robpercival@google.com> Reviewed-by: Emilia Käsper <emilia@openssl.org>
* Fix memory leak on invalid CertificateRequest.David Benjamin2016-04-071-0/+2
| | | | | | | | | | | | | | Free up parsed X509_NAME structure if the CertificateRequest message contains excess data. The security impact is considered insignificant. This is a client side only leak and a large number of connections to malicious servers would be needed to have a significant impact. This was found by libFuzzer. Reviewed-by: Emilia Käsper <emilia@openssl.org> Reviewed-by: Stephen Henson <steve@openssl.org>
* OpenSSL::Test: when moving directory, affect env as wellRichard Levitte2016-04-071-0/+22
| | | | | | | | | The environment variables TOP, SRCTOP, BLDTOP, ... are used to affect the testing framework. However, subprocesses may want to use them as well, and therefore need their values corrected when we move to a different directory. Reviewed-by: Emilia Käsper <emilia@openssl.org>
* Allow generate_ssl_tests.pl to find testlibEmilia Kasper2016-04-071-0/+1
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* Remove redundant symlinkEmilia Kasper2016-04-071-7/+1
| | | | | | | | | We used to symlink generate_ssl_tests.pl to the build directory. Now that the build scripts look for sources in both directories, this is no longer necessary (see commit fbd361eaf84446e8d6860ab2b7ecf9d04585f2ef). Reviewed-by: Richard Levitte <levitte@openssl.org>