aboutsummaryrefslogtreecommitdiffstats
path: root/engines
Commit message (Collapse)AuthorAgeFilesLines
* free NULL cleanup -- codaRich Salz2015-05-012-7/+6
| | | | | | | | After the finale, the "real" final part. :) Do a recursive grep with "-B1 -w [a-zA-Z0-9_]*_free" to see if any of the preceeding lines are an "if NULL" check that can be removed. Reviewed-by: Tim Hudson <tjh@openssl.org>
* free NULL cleanup 11Rich Salz2015-05-017-16/+8
| | | | | | | | | | | | | | | | | | | Don't check for NULL before calling free functions. This gets: ERR_STATE_free ENGINE_free DSO_free CMAC_CTX_free COMP_CTX_free CONF_free NCONF_free NCONF_free_data _CONF_free_data A sk_free use within OBJ_sigid_free TS_TST_INFO_free (rest of TS_ API was okay) Doc update for UI_free (all uses were fine) X509V3_conf_free X509V3_section_free X509V3_string_free Reviewed-by: Richard Levitte <levitte@openssl.org>
* free null cleanup finaleRich Salz2015-05-0111-74/+40
| | | | | | Don't check for NULL before calling OPENSSL_free Reviewed-by: Richard Levitte <levitte@openssl.org>
* free NULL cleanup 7Rich Salz2015-04-305-94/+39
| | | | | | | | | | | This gets BN_.*free: BN_BLINDING_free BN_CTX_free BN_FLG_FREE BN_GENCB_free BN_MONT_CTX_free BN_RECP_CTX_free BN_clear_free BN_free BUF_MEM_free Also fix a call to DSA_SIG_free to ccgost engine and remove some #ifdef'd dead code in engines/e_ubsec. Reviewed-by: Richard Levitte <levitte@openssl.org>
* free cleanup almost the finaleRich Salz2015-04-302-12/+5
| | | | | | | | | | Add OPENSSL_clear_free which merges cleanse and free. (Names was picked to be similar to BN_clear_free, etc.) Removed OPENSSL_freeFunc macro. Fixed the small simple ones that are left: CRYPTO_free CRYPTO_free_locked OPENSSL_free_locked Reviewed-by: Richard Levitte <levitte@openssl.org>
* remove malloc castsRich Salz2015-04-282-2/+2
| | | | | | | Following ANSI C rules, remove the casts from calls to OPENSSL_malloc and OPENSSL_realloc. Reviewed-by: Richard Levitte <levitte@openssl.org>
* Code style: space after 'if'Viktor Dukhovni2015-04-164-52/+55
| | | | Reviewed-by: Matt Caswell <matt@openssl.org>
* Initialize variableEmilia Kasper2015-04-151-1/+1
| | | | | | newsig may be used (freed) uninitialized on a malloc error. Reviewed-by: Rich Salz <rsalz@openssl.org>
* Remove EXHEADER, TEST, APPS, links:, install: and uninstall: where relevantRichard Levitte2015-03-312-12/+1
| | | | | | | | | | | | With no more symlinks, there's no need for those variables, or the links target. This also goes for all install: and uninstall: targets that do nothing but copy $(EXHEADER) files, since that's now taken care of by the top Makefile. Also, removed METHTEST from test/Makefile. It looks like an old test that's forgotten... Reviewed-by: Rich Salz <rsalz@openssl.org>
* Stop symlinking, move files to intended directoryRichard Levitte2015-03-311-1437/+0
| | | | | | | | | | | | | Rather than making include/openssl/foo.h a symlink to crypto/foo/foo.h, this change moves the file to include/openssl/foo.h once and for all. Likewise, move crypto/foo/footest.c to test/footest.c, instead of symlinking it there. Originally-by: Geoff Thorpe <geoff@openssl.org> Reviewed-by: Rich Salz <rsalz@openssl.org>
* Initialised 'ok' and redo the logic.Richard Levitte2015-03-301-4/+4
| | | | | | | The logic with how 'ok' was calculated didn't quite convey what's "ok", so the logic is slightly redone to make it less confusing. Reviewed-by: Andy Polyakov <appro@openssl.org>
* free NULL cleanupRich Salz2015-03-282-6/+4
| | | | | | | | | EVP_.*free; this gets: EVP_CIPHER_CTX_free EVP_PKEY_CTX_free EVP_PKEY_asn1_free EVP_PKEY_asn1_set_free EVP_PKEY_free EVP_PKEY_free_it EVP_PKEY_meth_free; and also EVP_CIPHER_CTX_cleanup Reviewed-by: Kurt Roeckx <kurt@openssl.org>
* free NULL cleanup.Rich Salz2015-03-251-3/+1
| | | | | | | This gets EC_GROUP_clear_free EC_GROUP_free, EC_KEY_free, EC_POINT_clear_free, EC_POINT_free Reviewed-by: Kurt Roeckx <kurt@openssl.org>
* free NULL cleanupRich Salz2015-03-252-12/+6
| | | | | | | This commit handles BIO_ACCEPT_free BIO_CB_FREE BIO_CONNECT_free BIO_free BIO_free_all BIO_vfree Reviewed-by: Matt Caswell <matt@openssl.org>
* Fix return checks in GOST engineMatt Caswell2015-03-256-71/+279
| | | | | | | Filled in lots of return value checks that were missing the GOST engine, and added appropriate error handling. Reviewed-by: Richard Levitte <levitte@openssl.org>
* Fix misc NULL derefs in sureware engineMatt Caswell2015-03-251-11/+16
| | | | | | Fix miscellaneous NULL pointer derefs in the sureware engine. Reviewed-by: Richard Levitte <levitte@openssl.org>
* free NULL cleanupRich Salz2015-03-244-13/+6
| | | | | | | | Start ensuring all OpenSSL "free" routines allow NULL, and remove any if check before calling them. This gets DH_free, DSA_free, RSA_free Reviewed-by: Matt Caswell <matt@openssl.org>
* make ASN1_OBJECT opaqueDr. Stephen Henson2015-03-241-2/+2
| | | | Reviewed-by: Matt Caswell <matt@openssl.org>
* Fix null-pointer dereferenceEdgar Pek2015-02-221-2/+2
| | | | | Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Richard Levitte <levitte@openssl.org>
* Transfer a fix from 1.0.1Richard Levitte2015-02-131-0/+4
| | | | | manually picked from e7b85bc40200961984925604ca444517359a6067 Reviewed-by: Stephen Henson <steve@openssl.org>
* Remove X509_PAIRRich Salz2015-02-061-1/+0
| | | | | | Unused type; a pair X509 certificates. Intended for LDAP support. Reviewed-by: Richard Levitte <levitte@openssl.org>
* Live code cleanup: remove #if 1 stuffRich Salz2015-02-061-3/+4
| | | | | | | For code bracketed by "#if 1" then remove the alternate "#else .. #endif" lines. Reviewed-by: Andy Polyakov <appro@openssl.org>
* Build correctly for me on FreeBSD 10.Ben Laurie2015-01-301-0/+1
| | | | | | Reviewed-by: Rich Salz Don't debug.
* Dead code removal #if 0 enginesRich Salz2015-01-304-124/+0
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* VMS adjustments:Richard Levitte2015-01-301-15/+9
| | | | | | | | catch up with the Unix build. A number of new tests, among others test/tocsp.com Define INTERNAL in ssl/ssl-lib.com to allow for '#include "internal/foo.h"' Reviewed-by: Andy Polyakov <appro@openssl.org>
* Make output consistency: remove blank lineRich Salz2015-01-291-1/+0
| | | | | | | | When you use "-s" in the make flag, you see that engines outputs a blank line because EDIRS isn't set. This is a debug echo that isn't needed. Reviewed-by: Richard Levitte <levitte@openssl.org>
* clang on Linux x86_64 complains about unreachable code.Richard Levitte2015-01-292-8/+0
| | | | Reviewed-by: Rich Salz <rsalz@openssl.org>
* OPENSSL_NO_xxx cleanup: SHARich Salz2015-01-271-2/+0
| | | | | | | | | | | | | | | Remove support for SHA0 and DSS0 (they were broken), and remove the ability to attempt to build without SHA (it didn't work). For simplicity, remove the option of not building various SHA algorithms; you could argue that SHA_224/256/384/512 should be kept, since they're like crypto algorithms, but I decided to go the other way. So these options are gone: GENUINE_DSA OPENSSL_NO_SHA0 OPENSSL_NO_SHA OPENSSL_NO_SHA1 OPENSSL_NO_SHA224 OPENSSL_NO_SHA256 OPENSSL_NO_SHA384 OPENSSL_NO_SHA512 Reviewed-by: Richard Levitte <levitte@openssl.org>
* More comment realignmentmaster-post-reformatMatt Caswell2015-01-222-18/+18
| | | | Reviewed-by: Tim Hudson <tjh@openssl.org>
* Re-align some comments after running the reformat script.Matt Caswell2015-01-221-120/+120
| | | | | | | This should be a one off operation (subsequent invokation of the script should not move them) Reviewed-by: Tim Hudson <tjh@openssl.org>
* Run util/openssl-format-source -v -c .Matt Caswell2015-01-2263-17053/+17097
| | | | Reviewed-by: Tim Hudson <tjh@openssl.org>
* Move more comments that confuse indentMatt Caswell2015-01-223-5/+12
| | | | Reviewed-by: Tim Hudson <tjh@openssl.org>
* Fix strange formatting by indentMatt Caswell2015-01-222-14/+14
| | | | Reviewed-by: Tim Hudson <tjh@openssl.org>
* engines/e_ubsec.c: make it indent-friendly.Andy Polyakov2015-01-221-17/+26
| | | | Reviewed-by: Tim Hudson <tjh@openssl.org>
* More commentsMatt Caswell2015-01-221-2/+4
| | | | | | | | | | | | | | | | | Conflicts: crypto/dsa/dsa_vrf.c crypto/ec/ec2_smpl.c crypto/ec/ecp_smpl.c Conflicts: demos/bio/saccept.c ssl/d1_clnt.c Conflicts: bugs/dggccbug.c demos/tunala/cb.c Reviewed-by: Tim Hudson <tjh@openssl.org>
* Cleanup OPENSSL_NO_xxx, part 1master-pre-reformatRich Salz2015-01-141-1/+1
| | | | | | | | | | OPENSSL_NO_RIPEMD160, OPENSSL_NO_RIPEMD merged into OPENSSL_NO_RMD160 OPENSSL_NO_FP_API merged into OPENSSL_NO_STDIO Two typo's on #endif comments fixed: OPENSSL_NO_ECB fixed to OPENSSL_NO_OCB OPENSSL_NO_HW_SureWare fixed to OPENSSL_NO_HW_SUREWARE Reviewed-by: Richard Levitte <levitte@openssl.org>
* For master windows build dsa.h is now needed.Dr. Stephen Henson2015-01-131-0/+1
| | | | Reviewed-by: Matt Caswell <matt@openssl.org>
* RT3548: Remove some unsupported platforms.Rich Salz2015-01-122-2/+0
| | | | | | | | | This commit removes NCR, Tandem, Cray. Regenerates TABLE. Removes another missing BEOS fluff. The last platform remaining on this ticket is WIN16. Reviewed-by: Richard Levitte <levitte@openssl.org>
* Further comment amendments to preserve formatting prior to source reformatMatt Caswell2015-01-061-1/+2
| | | | Reviewed-by: Tim Hudson <tjh@openssl.org>
* mark all block comments that need format preserving so thatTim Hudson2014-12-3010-68/+92
| | | | | | | indent will not alter them when reformatting comments Reviewed-by: Rich Salz <rsalz@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org>
* Rename gost2814789t.c to gost2814789test.c. The old name caused problemsMatt Caswell2014-12-162-1/+1
| | | | | | | | for dummytest if gost is compiled out, since the name of the test is not standard (dummytest segfaults). Also the old name caused problems for git because the executable was not in the .gitignore file Reviewed-by: Emilia Käsper <emilia@openssl.org>
* make updateMatt Caswell2014-12-111-10/+12
| | | | Reviewed-by: Tim Hudson <tjh@openssl.org>
* capi_ctrl, capi_vtrace: check for NULL after allocating and free itKurt Roeckx2014-12-103-1/+16
| | | | Reviewed-by: Matt Caswell <matt@openssl.org>
* Disable engines that will fail to build when bn is made opaqueMatt Caswell2014-12-081-132/+4
| | | | Reviewed-by: Tim Hudson <tjh@openssl.org>
* Fix broken buildEmilia Kasper2014-12-054-3/+4
| | | | | | Add includes missing from commit 33eab3f6af51c6d7fe68ee4960930df4f1616bd5 Reviewed-by: Geoff Thorpe <geoff@openssl.org>
* Replace GOST_R_MALLOC_FAILURE and GOST_R_NO_MEMORY with ERR_R_MALLOC_FAILUREKurt Roeckx2014-12-046-13/+9
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* capi_get_provname: Check return valuesKurt Roeckx2014-12-041-6/+12
| | | | Reviewed-by: Richard Levitte <levitte@openssl.org>
* capi_get_key: check for NULL after allocating keyJonas Maebe2014-12-041-0/+2
| | | | | Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Richard Levitte <levitte@openssl.org>
* capi_cert_get_fname: check for NULL after allocating wfnameJonas Maebe2014-12-041-0/+2
| | | | | Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Richard Levitte <levitte@openssl.org>
* capi_get_provname: free name on error if it was malloc'edJonas Maebe2014-12-041-0/+2
| | | | | Signed-off-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Richard Levitte <levitte@openssl.org>