From 2110febb117f477cbcaf6c8fe724848b57f5d433 Mon Sep 17 00:00:00 2001 From: Richard Levitte Date: Wed, 6 Apr 2016 15:02:57 +0200 Subject: Perl cleanup: don't create lists unnecessarily Reviewed-by: Rich Salz --- Configure | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'Configure') diff --git a/Configure b/Configure index c1b63e8933..ef5ff9f2e7 100755 --- a/Configure +++ b/Configure @@ -743,9 +743,9 @@ while (@tocheckfor) { while (@cascade_copy) { my ($test, $descendents) = (shift @cascade_copy, shift @cascade_copy); if (ref($test) eq "CODE" ? $test->() : defined($disabled{$test})) { - map { + foreach(grep { !defined($disabled{$_}) } @$descendents) { $new_tocheckfor{$_} = 1; $disabled{$_} = "forced"; - } grep { !defined($disabled{$_}) } @$descendents; + } } } @tocheckfor = (keys %new_tocheckfor); @@ -2128,12 +2128,12 @@ sub resolve_config { # the config that had it. delete $inherited_config{template}; - map { + foreach (keys %inherited_config) { if (!$combined_inheritance{$_}) { $combined_inheritance{$_} = []; } push @{$combined_inheritance{$_}}, $inherited_config{$_}; - } keys %inherited_config; + } } } @@ -2415,7 +2415,7 @@ sub quotify { my $processor = defined($processors{$for}) ? $processors{$for} : sub { shift; }; - map { $processor->($_); } @_; + return map { $processor->($_); } @_; } # collect_from_file($filename, $line_concat_cond_re, $line_concat) -- cgit v1.2.3