From 18295f0c2db084fe00d935d8506d6e964f652d21 Mon Sep 17 00:00:00 2001 From: Richard Levitte Date: Sun, 14 Feb 2016 13:02:15 +0100 Subject: Make sure to use unsigned char for is*() functions On some platforms, the implementation is such that a signed char triggers a warning when used with is*() functions. On others, the behavior is outright buggy when presented with a char that happens to get promoted to a negative integer. The safest thing is to cast the char that's used to an unsigned char. Reviewed-by: Andy Polyakov --- apps/apps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'apps/apps.c') diff --git a/apps/apps.c b/apps/apps.c index 7a4608f75c..2a189f20a0 100644 --- a/apps/apps.c +++ b/apps/apps.c @@ -183,7 +183,7 @@ int chopup_args(ARGS *arg, char *buf) for (p = buf;;) { /* Skip whitespace. */ - while (*p && isspace(*p)) + while (*p && isspace(_UC(*p))) p++; if (!*p) break; @@ -207,7 +207,7 @@ int chopup_args(ARGS *arg, char *buf) p++; *p++ = '\0'; } else { - while (*p && !isspace(*p)) + while (*p && !isspace(_UC(*p))) p++; if (*p) *p++ = '\0'; -- cgit v1.2.3