From c5ebfcab713a82a1d46a51c8c2668c419425b387 Mon Sep 17 00:00:00 2001 From: FdaSilvaYY Date: Mon, 7 Mar 2016 22:45:58 +0100 Subject: Unify _up_ref methods signature and behaviour. Add a status return value instead of void. Add some sanity checks on reference counter value. Update the docs. Reviewed-by: Rich Salz Reviewed-by: Matt Caswell --- crypto/x509/x509cset.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'crypto/x509/x509cset.c') diff --git a/crypto/x509/x509cset.c b/crypto/x509/x509cset.c index ab5f192a15..d8259254f0 100644 --- a/crypto/x509/x509cset.c +++ b/crypto/x509/x509cset.c @@ -132,10 +132,16 @@ int X509_CRL_sort(X509_CRL *c) return 1; } -void X509_CRL_up_ref(X509_CRL *crl) +int X509_CRL_up_ref(X509_CRL *crl) { int i; - CRYPTO_atomic_add(&crl->references, 1, &i, crl->lock); + + if (CRYPTO_atomic_add(&crl->references, 1, &i, crl->lock) <= 0) + return 0; + + REF_PRINT_COUNT("X509_CRL", crl); + REF_ASSERT_ISNT(i < 2); + return ((i > 1) ? 1 : 0); } long X509_CRL_get_version(X509_CRL *crl) -- cgit v1.2.3