From 59088414bc3b863a3dc287de76c53464bd7ff6fa Mon Sep 17 00:00:00 2001 From: Tomas Mraz Date: Mon, 19 Apr 2021 15:34:59 +0200 Subject: Removed dead code in linebuffer_ctrl() Fixes Coverity CID 1476284 Also add possible number truncation check. Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/14928) --- crypto/bio/bf_lbuf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crypto') diff --git a/crypto/bio/bf_lbuf.c b/crypto/bio/bf_lbuf.c index e9b946fe87..946ff0d23b 100644 --- a/crypto/bio/bf_lbuf.c +++ b/crypto/bio/bf_lbuf.c @@ -232,12 +232,12 @@ static long linebuffer_ctrl(BIO *b, int cmd, long num, void *ptr) } break; case BIO_C_SET_BUFF_SIZE: + if (num > INT_MAX) + return 0; obs = (int)num; p = ctx->obuf; if ((obs > DEFAULT_LINEBUFFER_SIZE) && (obs != ctx->obuf_size)) { - if (num <= 0) - return 0; - p = OPENSSL_malloc((size_t)num); + p = OPENSSL_malloc((size_t)obs); if (p == NULL) goto malloc_error; } -- cgit v1.2.3