aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKazuki Yamaguchi <k@rhe.jp>2017-11-22 14:56:05 +0900
committerKazuki Yamaguchi <k@rhe.jp>2017-11-22 14:56:05 +0900
commit8e79900909c152ad11b88d5cc8533918cca07709 (patch)
treef3f756b48c3ceae21dc17f7dbcfcdc6492437c98
parent8d123831818316ee9d7c8bb629c13fc056cc92ca (diff)
downloadruby-openssl-8e79900909c152ad11b88d5cc8533918cca07709.tar.gz
test/test_x509crl: fix random failureky/x509-implement-eq
Similarly to the previous one, avoid querying the current time multiple times. Fixes: e4727829837a ("x509crl, x509revoked: implement X509::{CRL,Revoked}#==", 2017-10-12)
-rw-r--r--test/test_x509crl.rb8
1 files changed, 5 insertions, 3 deletions
diff --git a/test/test_x509crl.rb b/test/test_x509crl.rb
index a11073fb..03fdf64d 100644
--- a/test/test_x509crl.rb
+++ b/test/test_x509crl.rb
@@ -221,11 +221,13 @@ class OpenSSL::TestX509CRL < OpenSSL::TestCase
end
def test_eq
+ now = Time.now
+
cacert = issue_cert(@ca, @rsa1024, 1, [], nil, nil)
- crl1 = issue_crl([], 1, Time.now, Time.now + 3600, [], cacert, @rsa1024, "sha256")
+ crl1 = issue_crl([], 1, now, now + 3600, [], cacert, @rsa1024, "sha256")
rev1 = OpenSSL::X509::Revoked.new.tap { |rev|
rev.serial = 1
- rev.time = Time.now
+ rev.time = now
}
crl1.add_revoked(rev1)
crl2 = OpenSSL::X509::CRL.new(crl1.to_der)
@@ -235,7 +237,7 @@ class OpenSSL::TestX509CRL < OpenSSL::TestCase
assert_equal true, crl1 == crl2
rev2 = OpenSSL::X509::Revoked.new.tap { |rev|
rev.serial = 2
- rev.time = Time.now
+ rev.time = now
}
crl2.add_revoked(rev2)
assert_equal false, crl1 == crl2