diff options
| author | Nobuhiro IMAI <nov@yo.rim.or.jp> | 2022-08-05 18:42:06 +0900 |
|---|---|---|
| committer | Nobuhiro IMAI <nov@yo.rim.or.jp> | 2022-08-08 18:37:49 +0900 |
| commit | ef2352521089998842672106d2c988387ffb6698 (patch) | |
| tree | 7bac4e2ed1e19fe0eee10f07ca1b23506981351b | |
| parent | ee64d93cb20e7fca80eddbf711c56ae2fac9a825 (diff) | |
| download | ruby-openssl-ef2352521089998842672106d2c988387ffb6698.tar.gz | |
Check if the option is an Hash in `pkey_ctx_apply_options0()`
causes SEGV if it is an Array or something like that.
| -rw-r--r-- | ext/openssl/ossl_pkey.c | 1 | ||||
| -rw-r--r-- | test/openssl/test_pkey_rsa.rb | 5 |
2 files changed, 6 insertions, 0 deletions
diff --git a/ext/openssl/ossl_pkey.c b/ext/openssl/ossl_pkey.c index 2a4835a2..7fcb570c 100644 --- a/ext/openssl/ossl_pkey.c +++ b/ext/openssl/ossl_pkey.c @@ -200,6 +200,7 @@ static VALUE pkey_ctx_apply_options0(VALUE args_v) { VALUE *args = (VALUE *)args_v; + Check_Type(args[1], T_HASH); rb_block_call(args[1], rb_intern("each"), 0, NULL, pkey_ctx_apply_options_i, args[0]); diff --git a/test/openssl/test_pkey_rsa.rb b/test/openssl/test_pkey_rsa.rb index 4bb39ed4..fa84b76f 100644 --- a/test/openssl/test_pkey_rsa.rb +++ b/test/openssl/test_pkey_rsa.rb @@ -108,6 +108,11 @@ class OpenSSL::TestPKeyRSA < OpenSSL::PKeyTestCase salt_length: 20, mgf1_hash: "SHA1") # Defaults to PKCS #1 v1.5 padding => verification failure assert_equal false, key.verify("SHA256", sig_pss, data) + + # option type check + assert_raise_with_message(TypeError, /expected Hash/) { + key.sign("SHA256", data, ["x"]) + } end def test_sign_verify_raw |