diff options
| author | Kazuki Yamaguchi <k@rhe.jp> | 2020-08-12 18:51:14 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-12 18:51:14 +0900 |
| commit | ad24cc35e8819041195401c09d73d6c71898ec73 (patch) | |
| tree | 185720102fab5189e968472c5593649099d18589 | |
| parent | 9b46c6a603b07ba4f930b4afb58a7ae76c86eadd (diff) | |
| parent | 9561199b9f8d95dced791ab83158b11cf1e4ba61 (diff) | |
| download | ruby-openssl-ad24cc35e8819041195401c09d73d6c71898ec73.tar.gz | |
Merge pull request #391 from rhenium/ky/x509stctx-new-fix-leak
x509store: fix memory leak in X509::StoreContext.new
| -rw-r--r-- | ext/openssl/ossl_x509store.c | 21 |
1 files changed, 16 insertions, 5 deletions
diff --git a/ext/openssl/ossl_x509store.c b/ext/openssl/ossl_x509store.c index 61543d44..6c5f1c79 100644 --- a/ext/openssl/ossl_x509store.c +++ b/ext/openssl/ossl_x509store.c @@ -517,7 +517,9 @@ static VALUE ossl_x509stctx_set_time(VALUE, VALUE); /* * call-seq: - * StoreContext.new(store, cert = nil, chain = nil) + * StoreContext.new(store, cert = nil, untrusted = nil) + * + * Sets up a StoreContext for a verification of the X.509 certificate _cert_. */ static VALUE ossl_x509stctx_initialize(int argc, VALUE *argv, VALUE self) @@ -527,15 +529,24 @@ ossl_x509stctx_initialize(int argc, VALUE *argv, VALUE self) X509_STORE *x509st; X509 *x509 = NULL; STACK_OF(X509) *x509s = NULL; + int state; rb_scan_args(argc, argv, "12", &store, &cert, &chain); GetX509StCtx(self, ctx); GetX509Store(store, x509st); - if(!NIL_P(cert)) x509 = DupX509CertPtr(cert); /* NEED TO DUP */ - if(!NIL_P(chain)) x509s = ossl_x509_ary2sk(chain); - if(X509_STORE_CTX_init(ctx, x509st, x509, x509s) != 1){ + if (!NIL_P(cert)) + x509 = DupX509CertPtr(cert); /* NEED TO DUP */ + if (!NIL_P(chain)) { + x509s = ossl_protect_x509_ary2sk(chain, &state); + if (state) { + X509_free(x509); + rb_jump_tag(state); + } + } + if (X509_STORE_CTX_init(ctx, x509st, x509, x509s) != 1){ + X509_free(x509); sk_X509_pop_free(x509s, X509_free); - ossl_raise(eX509StoreError, NULL); + ossl_raise(eX509StoreError, "X509_STORE_CTX_init"); } if (!NIL_P(t = rb_iv_get(store, "@time"))) ossl_x509stctx_set_time(self, t); |