diff options
| author | Brian Cunnie <brian.cunnie@gmail.com> | 2018-01-29 20:08:49 -0800 |
|---|---|---|
| committer | Brian Cunnie <brian.cunnie@gmail.com> | 2018-02-06 06:37:50 -0800 |
| commit | 9322a104d16b02c7a79f9ab589859c9d63fabf52 (patch) | |
| tree | ea63f2d604f0e23b7990ef4e55d82bff04113548 /test/test_ssl.rb | |
| parent | f707996f80ab5e63fd584d576b9a39f091b22dca (diff) | |
| download | ruby-openssl-9322a104d16b02c7a79f9ab589859c9d63fabf52.tar.gz | |
Correctly verify abbreviated IPv6 SANs
IPv6 SAN-verification accommodates
["zero-compression"](https://tools.ietf.org/html/rfc5952#section-2.2).
It also accommodates non-compressed addresses.
Previously the verification of IPv6 addresses would fail unless the
address syntax matched a specific format (no zero-compression, no
leading zeroes).
As an example, the IPv6 loopback address, if represented as `::1`, would
not verify. Nor would it verify if represented as
`0000:0000:0000:0000:0000:0000:0000:0001`; however, both representations
are valid, RFC-compliant representations. The library would only accept
a very specific representation (i.e. `0:0:0:0:0:0:0:1`).
This commit addresses that shortcoming, and ensures that any valid IPv6
representation will correctly verify.
Diffstat (limited to 'test/test_ssl.rb')
| -rw-r--r-- | test/test_ssl.rb | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/test/test_ssl.rb b/test/test_ssl.rb index 3b063d2e..186de27d 100644 --- a/test/test_ssl.rb +++ b/test/test_ssl.rb @@ -516,8 +516,12 @@ class OpenSSL::TestSSL < OpenSSL::SSLTestCase assert_equal(true, OpenSSL::SSL.verify_certificate_identity(cert, "www.example.com\0.evil.com")) assert_equal(false, OpenSSL::SSL.verify_certificate_identity(cert, '192.168.7.255')) assert_equal(true, OpenSSL::SSL.verify_certificate_identity(cert, '192.168.7.1')) - assert_equal(false, OpenSSL::SSL.verify_certificate_identity(cert, '13::17')) + assert_equal(true, OpenSSL::SSL.verify_certificate_identity(cert, '13::17')) + assert_equal(false, OpenSSL::SSL.verify_certificate_identity(cert, '13::18')) assert_equal(true, OpenSSL::SSL.verify_certificate_identity(cert, '13:0:0:0:0:0:0:17')) + assert_equal(false, OpenSSL::SSL.verify_certificate_identity(cert, '44:0:0:0:0:0:0:17')) + assert_equal(true, OpenSSL::SSL.verify_certificate_identity(cert, '0013:0000:0000:0000:0000:0000:0000:0017')) + assert_equal(false, OpenSSL::SSL.verify_certificate_identity(cert, '1313:0000:0000:0000:0000:0000:0000:0017')) end end |