aboutsummaryrefslogtreecommitdiffstats
path: root/test/test_ossl.rb
diff options
context:
space:
mode:
Diffstat (limited to 'test/test_ossl.rb')
-rw-r--r--test/test_ossl.rb36
1 files changed, 18 insertions, 18 deletions
diff --git a/test/test_ossl.rb b/test/test_ossl.rb
index b23b3792..85363cb5 100644
--- a/test/test_ossl.rb
+++ b/test/test_ossl.rb
@@ -6,28 +6,28 @@ require 'benchmark'
if defined?(OpenSSL)
class OpenSSL::OSSL < OpenSSL::SSLTestCase
- def test_secure_compare
- assert_raises(ArgumentError) { OpenSSL.secure_compare("aaa", "a") }
- assert_raises(ArgumentError) { OpenSSL.secure_compare("aaa", "aa") }
+ def test_fixed_length_secure_compare
+ assert_raises(ArgumentError) { OpenSSL.fixed_length_secure_compare("aaa", "a") }
+ assert_raises(ArgumentError) { OpenSSL.fixed_length_secure_compare("aaa", "aa") }
- assert OpenSSL.secure_compare("aaa", "aaa")
- assert OpenSSL.secure_compare(
+ assert OpenSSL.fixed_length_secure_compare("aaa", "aaa")
+ assert OpenSSL.fixed_length_secure_compare(
OpenSSL::Digest::SHA256.digest("aaa"), OpenSSL::Digest::SHA256.digest("aaa")
)
- assert_raises(ArgumentError) { OpenSSL.secure_compare("aaa", "aaaa") }
- refute OpenSSL.secure_compare("aaa", "baa")
- refute OpenSSL.secure_compare("aaa", "aba")
- refute OpenSSL.secure_compare("aaa", "aab")
- assert_raises(ArgumentError) { OpenSSL.secure_compare("aaa", "aaab") }
- assert_raises(ArgumentError) { OpenSSL.secure_compare("aaa", "b") }
- assert_raises(ArgumentError) { OpenSSL.secure_compare("aaa", "bb") }
- refute OpenSSL.secure_compare("aaa", "bbb")
- assert_raises(ArgumentError) { OpenSSL.secure_compare("aaa", "bbbb") }
+ assert_raises(ArgumentError) { OpenSSL.fixed_length_secure_compare("aaa", "aaaa") }
+ refute OpenSSL.fixed_length_secure_compare("aaa", "baa")
+ refute OpenSSL.fixed_length_secure_compare("aaa", "aba")
+ refute OpenSSL.fixed_length_secure_compare("aaa", "aab")
+ assert_raises(ArgumentError) { OpenSSL.fixed_length_secure_compare("aaa", "aaab") }
+ assert_raises(ArgumentError) { OpenSSL.fixed_length_secure_compare("aaa", "b") }
+ assert_raises(ArgumentError) { OpenSSL.fixed_length_secure_compare("aaa", "bb") }
+ refute OpenSSL.fixed_length_secure_compare("aaa", "bbb")
+ assert_raises(ArgumentError) { OpenSSL.fixed_length_secure_compare("aaa", "bbbb") }
end
def test_memcmp_timing
- # Ensure using secure_compare takes almost exactly the same amount of time to compare two different strings.
+ # Ensure using fixed_length_secure_compare takes almost exactly the same amount of time to compare two different strings.
# Regular string comparison will short-circuit on the first non-matching character, failing this test.
# NOTE: this test may be susceptible to noise if the system running the tests is otherwise under load.
a = "x" * 512_000
@@ -36,9 +36,9 @@ class OpenSSL::OSSL < OpenSSL::SSLTestCase
a = "#{a}x"
n = 10_000
- a_b_time = Benchmark.measure { n.times { OpenSSL.secure_compare(a, b) } }.real
- a_c_time = Benchmark.measure { n.times { OpenSSL.secure_compare(a, c) } }.real
- assert_in_delta(a_b_time, a_c_time, 1, "secure_compare timing test failed")
+ a_b_time = Benchmark.measure { n.times { OpenSSL.fixed_length_secure_compare(a, b) } }.real
+ a_c_time = Benchmark.measure { n.times { OpenSSL.fixed_length_secure_compare(a, c) } }.real
+ assert_in_delta(a_b_time, a_c_time, 1, "fixed_length_secure_compare timing test failed")
end
end