diff options
author | tmm1 <tmm1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2014-01-06 19:38:20 +0000 |
---|---|---|
committer | tmm1 <tmm1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2014-01-06 19:38:20 +0000 |
commit | 3cf4fe47e80548011c5c136c7447f24b587c40e6 (patch) | |
tree | eddb9de7ba3b97653075caf38365dbd355b732b7 | |
parent | 7dfbcc85d2e31fcb9af50c66486e82e1bc4dc2df (diff) | |
download | ruby-3cf4fe47e80548011c5c136c7447f24b587c40e6.tar.gz |
array.c: return first unique element in Array#uniq
* array.c (ary_add_hash): Fix consistency issue between Array#uniq and
Array#uniq! [Bug #9340] [ruby-core:59457]
* test/ruby/test_array.rb (class TestArray): regression test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44512 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | ChangeLog | 6 | ||||
-rw-r--r-- | array.c | 4 | ||||
-rw-r--r-- | test/ruby/test_array.rb | 5 |
3 files changed, 14 insertions, 1 deletions
@@ -1,3 +1,9 @@ +Tue Jan 7 04:35:46 2014 Aman Gupta <ruby@tmm1.net> + + * array.c (ary_add_hash): Fix consistency issue between Array#uniq and + Array#uniq! [Bug #9340] [ruby-core:59457] + * test/ruby/test_array.rb (class TestArray): regression test for above. + Mon Jan 6 21:28:48 2014 Kazuhiro NISHIYAMA <zn@mbf.nifty.com> * .gitignore: ignore *-fake.rb generated even when CROSS_COMPILING = no @@ -3908,7 +3908,9 @@ ary_add_hash(VALUE hash, VALUE ary) for (i=0; i<RARRAY_LEN(ary); i++) { VALUE elt = RARRAY_AREF(ary, i); - rb_hash_aset(hash, elt, elt); + if (rb_hash_lookup2(hash, elt, Qundef) == Qundef) { + rb_hash_aset(hash, elt, elt); + } } return hash; } diff --git a/test/ruby/test_array.rb b/test/ruby/test_array.rb index b648c404ed..6ff304acb2 100644 --- a/test/ruby/test_array.rb +++ b/test/ruby/test_array.rb @@ -1524,6 +1524,11 @@ class TestArray < Test::Unit::TestCase assert(a.none?(&:frozen?)) assert_equal(%w(a), b) assert(b.none?(&:frozen?)) + + bug9340 = "[ruby-core:59457]" + ary = [bug9340, bug9340.dup, bug9340.dup] + assert_equal 1, ary.uniq.size + assert_same bug9340, ary.uniq[0] end def test_uniq_with_block |