diff options
author | nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2016-06-13 11:50:09 +0000 |
---|---|---|
committer | nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2016-06-13 11:50:09 +0000 |
commit | 49f0d188f57800e97d24ccffbe5874d0958a1696 (patch) | |
tree | db1e72fb93e9f0f0765c233c2246d8283e83a0a8 | |
parent | 4e54ee7fdf2bea18344e5f60f6563bea2def2ed1 (diff) | |
download | ruby-49f0d188f57800e97d24ccffbe5874d0958a1696.tar.gz |
parse.y: no named capture conflict warnings
* parse.y (reg_named_capture_assign_iter): remove named capture
conflict warnings. it is just annoying rather than useful.
[ruby-core:75416] [Bug #12359]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | ChangeLog | 6 | ||||
-rw-r--r-- | parse.y | 4 | ||||
-rw-r--r-- | test/ruby/test_parse.rb | 4 |
3 files changed, 8 insertions, 6 deletions
@@ -1,3 +1,9 @@ +Mon Jun 13 20:50:07 2016 Nobuyoshi Nakada <nobu@ruby-lang.org> + + * parse.y (reg_named_capture_assign_iter): remove named capture + conflict warnings. it is just annoying rather than useful. + [ruby-core:75416] [Bug #12359] + Mon Jun 13 20:04:00 2016 Kenta Murata <mrkn@mrkn.jp> * numeric.c (rb_int_digits, rb_fix_digits, rb_int_digits_bigbase): @@ -10616,10 +10616,6 @@ reg_named_capture_assign_iter(const OnigUChar *name, const OnigUChar *name_end, return ST_CONTINUE; } var = intern_cstr(s, len, enc); - if (dvar_defined(var) || local_id(var)) { - rb_warning1("named capture conflicts a local variable - %"PRIsWARN, - rb_id2str(var)); - } node = newline_node(node_assign(assignable(var, 0), NEW_LIT(ID2SYM(var)))); succ = arg->succ_block; if (!succ) succ = NEW_BEGIN(0); diff --git a/test/ruby/test_parse.rb b/test/ruby/test_parse.rb index 9f83598ceb..eca1744b96 100644 --- a/test/ruby/test_parse.rb +++ b/test/ruby/test_parse.rb @@ -869,9 +869,9 @@ x = __ENCODING__ def test_named_capture_conflict a = 1 - assert_warning(/named capture conflict/) {eval("a = 1; /(?<a>)/ =~ ''")} + assert_warning('') {eval("a = 1; /(?<a>)/ =~ ''")} a = "\u{3042}" - assert_warning(/#{a}/) {eval("#{a} = 1; /(?<#{a}>)/ =~ ''")} + assert_warning('') {eval("#{a} = 1; /(?<#{a}>)/ =~ ''")} end =begin |