diff options
author | ko1 <ko1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2007-08-17 07:24:03 +0000 |
---|---|---|
committer | ko1 <ko1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2007-08-17 07:24:03 +0000 |
commit | e5d5f5a61a484c5d3993cee2c02c4f501a6f74f8 (patch) | |
tree | ff3ca5ce3ebab048ad224febd7d4ced5bb724b03 | |
parent | 82a9ca296b69144212c10b66eb932555310bd973 (diff) | |
download | ruby-e5d5f5a61a484c5d3993cee2c02c4f501a6f74f8.tar.gz |
* thread.c (rb_thread_terminate_all): fix to ignore
exceptions.
* thread.c (thread_start_func_2): fix
abort_on_exception process. [ruby-dev:31394]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@13078 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | ChangeLog | 8 | ||||
-rw-r--r-- | thread.c | 26 |
2 files changed, 25 insertions, 9 deletions
@@ -1,3 +1,11 @@ +Fri Aug 17 16:02:50 2007 Koichi Sasada <ko1@atdot.net> + + * thread.c (rb_thread_terminate_all): fix to ignore + exceptions. + + * thread.c (thread_start_func_2): fix + abort_on_exception process. [ruby-dev:31394] + Fri Aug 17 14:38:36 2007 Tanaka Akira <akr@fsij.org> * bootstraptest/runner.rb (in_temporary_working_directory): use @@ -259,7 +259,14 @@ rb_thread_terminate_all(void) st_foreach(vm->living_threads, terminate_i, (st_data_t)th); while (!rb_thread_alone()) { - rb_thread_schedule(); + PUSH_TAG(); + if (EXEC_TAG() == 0) { + rb_thread_schedule(); + } + else { + /* ignore exception */ + } + POP_TAG(); } system_working = 0; } @@ -327,14 +334,20 @@ thread_start_func_2(rb_thread_t *th, VALUE *stack_start, VALUE *register_stack_s } th->value = Qnil; } - TH_POP_TAG(); th->status = THREAD_KILLED; thread_debug("thread end: %p\n", th); - st_delete_wrap(th->vm->living_threads, th->self); main_th = th->vm->main_thread; - if (th == main_th) errinfo = Qnil; + if (th != main_th) { + if (TYPE(errinfo) == T_OBJECT) { + /* treat with normal error object */ + rb_thread_raise(1, &errinfo, main_th); + } + } + TH_POP_TAG(); + + st_delete_wrap(th->vm->living_threads, th->self); /* wake up joinning threads */ join_th = th->join_list_head; @@ -348,11 +361,6 @@ thread_start_func_2(rb_thread_t *th, VALUE *stack_start, VALUE *register_stack_s thread_cleanup_func(th); native_mutex_unlock(&th->vm->global_interpreter_lock); - if (!NIL_P(errinfo)) { - /* exit on main_thread */ - rb_thread_raise(1, &errinfo, main_th); - } - return 0; } |