aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKazuki Yamaguchi <k@rhe.jp>2016-06-05 23:42:04 +0900
committerKazuki Yamaguchi <k@rhe.jp>2016-06-06 11:29:39 +0900
commitea1f3eabbf115535298629ac48ee219873dd6712 (patch)
tree64c1ad2ea42c6623b0e12e4e076141faca389631
parent62e5c73e03eb780a23d551672bea7ec92b0047ac (diff)
downloadruby-ea1f3eabbf115535298629ac48ee219873dd6712.tar.gz
ext/openssl: remove SHA, DSS, DSS1 if using OpenSSL 1.1.0
-rw-r--r--ext/openssl/lib/openssl/digest.rb5
-rw-r--r--test/openssl/test_digest.rb7
-rw-r--r--test/openssl/test_pkey_dsa.rb4
-rw-r--r--test/openssl/test_ssl.rb2
-rw-r--r--test/openssl/test_x509cert.rb2
-rw-r--r--test/openssl/test_x509req.rb2
6 files changed, 13 insertions, 9 deletions
diff --git a/ext/openssl/lib/openssl/digest.rb b/ext/openssl/lib/openssl/digest.rb
index 1240bf596b..1a236cc77d 100644
--- a/ext/openssl/lib/openssl/digest.rb
+++ b/ext/openssl/lib/openssl/digest.rb
@@ -15,7 +15,10 @@
module OpenSSL
class Digest
- alg = %w(DSS DSS1 MD2 MD4 MD5 MDC2 RIPEMD160 SHA SHA1)
+ alg = %w(MD2 MD4 MD5 MDC2 RIPEMD160 SHA1)
+ if OPENSSL_VERSION_NUMBER < 0x10100000
+ alg += %w(DSS DSS1 SHA)
+ end
if OPENSSL_VERSION_NUMBER > 0x00908000
alg += %w(SHA224 SHA256 SHA384 SHA512)
end
diff --git a/test/openssl/test_digest.rb b/test/openssl/test_digest.rb
index ba3e974bc6..c4f54cf13e 100644
--- a/test/openssl/test_digest.rb
+++ b/test/openssl/test_digest.rb
@@ -59,9 +59,10 @@ class OpenSSL::TestDigest < OpenSSL::TestCase
end
def test_digest_constants
- algs = %w(DSS1 MD4 MD5 RIPEMD160 SHA1)
- if !libressl? || !version_since([2,3])
- algs += %w(SHA)
+ algs = %w(MD4 MD5 RIPEMD160 SHA1)
+ if libressl? && !version_since([2,3]) ||
+ OpenSSL::OPENSSL_VERSION_NUMBER < 0x10100000
+ algs += %w(SHA DSS1)
end
if OpenSSL::OPENSSL_VERSION_NUMBER > 0x00908000
algs += %w(SHA224 SHA256 SHA384 SHA512)
diff --git a/test/openssl/test_pkey_dsa.rb b/test/openssl/test_pkey_dsa.rb
index 680a123997..f9cc9aefa7 100644
--- a/test/openssl/test_pkey_dsa.rb
+++ b/test/openssl/test_pkey_dsa.rb
@@ -39,7 +39,7 @@ class OpenSSL::TestPKeyDSA < OpenSSL::TestCase
def test_sign_verify
check_sign_verify(OpenSSL::Digest::DSS1.new)
- end
+ end if defined?(OpenSSL::Digest::DSS1)
if (OpenSSL::OPENSSL_VERSION_NUMBER > 0x10000000)
def test_sign_verify_sha1
@@ -61,7 +61,7 @@ end
digest1 << 'Change state of digest1'
assert(key.verify(digest1, sig, data))
assert(key.verify(digest2, sig, data))
- end
+ end if defined?(OpenSSL::Digest::DSS1)
def test_read_DSA_PUBKEY
p = 7188211954100152441468596248707152960171255279130004340103875772401008316444412091945435731597638374542374929457672178957081124632837356913990200866056699
diff --git a/test/openssl/test_ssl.rb b/test/openssl/test_ssl.rb
index 51f9e3d62d..9b986bf118 100644
--- a/test/openssl/test_ssl.rb
+++ b/test/openssl/test_ssl.rb
@@ -405,7 +405,7 @@ class OpenSSL::TestSSL < OpenSSL::SSLTestCase
ciphers = ctx.ciphers
ciphers_versions = ciphers.collect{|_, v, _, _| v }
ciphers_names = ciphers.collect{|v, _, _, _| v }
- assert(ciphers_names.all?{|v| /ADH/ !~ v })
+ assert(ciphers_names.all?{|v| /A(EC)?DH/ !~ v })
assert(ciphers_versions.all?{|v| /SSLv2/ !~ v })
ssl = OpenSSL::SSL::SSLSocket.new(sock, ctx)
ssl.sync_close = true
diff --git a/test/openssl/test_x509cert.rb b/test/openssl/test_x509cert.rb
index ae7a0f0855..269d017298 100644
--- a/test/openssl/test_x509cert.rb
+++ b/test/openssl/test_x509cert.rb
@@ -168,7 +168,7 @@ class OpenSSL::TestX509Certificate < OpenSSL::TestCase
cert.subject = @ee1
assert_equal(false, cert.verify(@rsa2048))
rescue OpenSSL::X509::CertificateError
- end
+ end if defined?(OpenSSL::Digest::DSS1)
def test_sign_and_verify_dsa_md5
assert_raise(OpenSSL::X509::CertificateError){
diff --git a/test/openssl/test_x509req.rb b/test/openssl/test_x509req.rb
index 7ceff5839b..53e5a437fc 100644
--- a/test/openssl/test_x509req.rb
+++ b/test/openssl/test_x509req.rb
@@ -140,7 +140,7 @@ class OpenSSL::TestX509Request < OpenSSL::TestCase
assert_equal(false, req.verify(@rsa1024))
rescue OpenSSL::X509::RequestError
skip
- end
+ end if defined?(OpenSSL::Digest::DSS1)
def test_sign_and_verify_dsa_md5
assert_raise(OpenSSL::X509::RequestError){