diff options
author | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2019-11-05 15:47:25 +0900 |
---|---|---|
committer | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2019-11-05 17:42:35 +0900 |
commit | dfb3322d27aa05f506818209ab6a10a77221b86d (patch) | |
tree | d3ccb678d621d7142572280cabc830d456c6d57f | |
parent | bea322a352d820007dd4e6cab88af5de01854736 (diff) | |
download | ruby-dfb3322d27aa05f506818209ab6a10a77221b86d.tar.gz |
`DottedFormatter#state` consistency
Let the method of `DottedFormatter` subclasses have the same
arity.
7 files changed, 7 insertions, 7 deletions
diff --git a/spec/mspec/lib/mspec/runner/formatters/html.rb b/spec/mspec/lib/mspec/runner/formatters/html.rb index fd64cd0d20..f79c7161f9 100644 --- a/spec/mspec/lib/mspec/runner/formatters/html.rb +++ b/spec/mspec/lib/mspec/runner/formatters/html.rb @@ -50,7 +50,7 @@ EOH print %[#{outcome} - #{@count}</a>)</li>\n] end - def after(state) + def after(state = nil) print %[<li class="pass">- #{state.it}</li>\n] unless exception? end diff --git a/spec/mspec/lib/mspec/runner/formatters/method.rb b/spec/mspec/lib/mspec/runner/formatters/method.rb index ff115193fd..8a460665ff 100644 --- a/spec/mspec/lib/mspec/runner/formatters/method.rb +++ b/spec/mspec/lib/mspec/runner/formatters/method.rb @@ -60,7 +60,7 @@ class MethodFormatter < DottedFormatter # Callback for the MSpec :after event. Sets or adds to # tallies for the example block. - def after(state) + def after(state = nil) h = methods[@key] h[:examples] += tally.counter.examples h[:expectations] += tally.counter.expectations diff --git a/spec/mspec/lib/mspec/runner/formatters/profile.rb b/spec/mspec/lib/mspec/runner/formatters/profile.rb index 498cd4a3b7..6d15a56349 100644 --- a/spec/mspec/lib/mspec/runner/formatters/profile.rb +++ b/spec/mspec/lib/mspec/runner/formatters/profile.rb @@ -38,7 +38,7 @@ class ProfileFormatter < DottedFormatter # Callback for the MSpec :after event. Prints a # newline to finish the description string output. - def after(state) + def after(state = nil) @its << [@describe_name, @it_name, Time.now.to_f - @it_time] super end diff --git a/spec/mspec/lib/mspec/runner/formatters/specdoc.rb b/spec/mspec/lib/mspec/runner/formatters/specdoc.rb index 29adde3c5c..06ac7702df 100644 --- a/spec/mspec/lib/mspec/runner/formatters/specdoc.rb +++ b/spec/mspec/lib/mspec/runner/formatters/specdoc.rb @@ -35,7 +35,7 @@ class SpecdocFormatter < DottedFormatter # Callback for the MSpec :after event. Prints a # newline to finish the description string output. - def after(state) + def after(state = nil) print "\n" end end diff --git a/spec/mspec/lib/mspec/runner/formatters/spinner.rb b/spec/mspec/lib/mspec/runner/formatters/spinner.rb index f6f35cc476..89791b687f 100644 --- a/spec/mspec/lib/mspec/runner/formatters/spinner.rb +++ b/spec/mspec/lib/mspec/runner/formatters/spinner.rb @@ -105,7 +105,7 @@ class SpinnerFormatter < DottedFormatter end # Callback for the MSpec :after event. Updates the spinner. - def after(state) + def after(state = nil) print progress_line end diff --git a/spec/mspec/lib/mspec/runner/formatters/summary.rb b/spec/mspec/lib/mspec/runner/formatters/summary.rb index 0c9207194c..2dfa751b57 100644 --- a/spec/mspec/lib/mspec/runner/formatters/summary.rb +++ b/spec/mspec/lib/mspec/runner/formatters/summary.rb @@ -5,7 +5,7 @@ class SummaryFormatter < DottedFormatter # Callback for the MSpec :after event. Overrides the # callback provided by +DottedFormatter+ and does not # print any output for each example evaluated. - def after(state) + def after(state = nil) # do nothing end end diff --git a/spec/mspec/lib/mspec/runner/formatters/yaml.rb b/spec/mspec/lib/mspec/runner/formatters/yaml.rb index 090a9b1b9d..bb98f7931e 100644 --- a/spec/mspec/lib/mspec/runner/formatters/yaml.rb +++ b/spec/mspec/lib/mspec/runner/formatters/yaml.rb @@ -16,7 +16,7 @@ class YamlFormatter < DottedFormatter @out = @finish end - def after(state) + def after(state = nil) end def finish |