aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authornagachika <nagachika@ruby-lang.org>2020-07-23 12:13:30 +0900
committernagachika <nagachika@ruby-lang.org>2020-07-23 12:13:30 +0900
commit27fa1c61b78c1685ccf9ac203a95cfa9041d618f (patch)
tree88ce359e50f4789a7479753ea91ec1adbebf5b2b
parent4be9bf1f67b997fc519625d56a93b8a68a70d124 (diff)
downloadruby-27fa1c61b78c1685ccf9ac203a95cfa9041d618f.tar.gz
merge revision(s) 579645d9f870fa4116dcd3200bbbb6e2c0b7f400: [Backport #17033]
Fixed infinite loop at error in printing cause [Bug #17033]
-rw-r--r--eval_error.c6
-rw-r--r--test/ruby/test_exception.rb20
-rw-r--r--version.h2
3 files changed, 26 insertions, 2 deletions
diff --git a/eval_error.c b/eval_error.c
index 847072ab98..9d2de6dbc5 100644
--- a/eval_error.c
+++ b/eval_error.c
@@ -348,6 +348,7 @@ rb_ec_error_print(rb_execution_context_t * volatile ec, volatile VALUE errinfo)
volatile uint8_t raised_flag = ec->raised_flag;
volatile VALUE errat = Qundef;
volatile VALUE emesg = Qundef;
+ volatile bool written = false;
if (NIL_P(errinfo))
return;
@@ -362,7 +363,10 @@ rb_ec_error_print(rb_execution_context_t * volatile ec, volatile VALUE errinfo)
emesg = rb_get_message(errinfo);
}
- rb_error_write(errinfo, emesg, errat, Qnil, Qnil, Qnil);
+ if (!written) {
+ written = true;
+ rb_error_write(errinfo, emesg, errat, Qnil, Qnil, Qnil);
+ }
EC_POP_TAG();
ec->errinfo = errinfo;
diff --git a/test/ruby/test_exception.rb b/test/ruby/test_exception.rb
index 79ac11ab26..69bf7ebf0e 100644
--- a/test/ruby/test_exception.rb
+++ b/test/ruby/test_exception.rb
@@ -824,6 +824,26 @@ end.join
}
end
+ def test_cause_exception_in_cause_message
+ assert_in_out_err([], "#{<<~"begin;"}\n#{<<~'end;'}") do |outs, errs, status|
+ begin;
+ exc = Class.new(StandardError) do
+ def initialize(obj, cnt)
+ super(obj)
+ @errcnt = cnt
+ end
+ def to_s
+ return super if @errcnt <= 0
+ @errcnt -= 1
+ raise "xxx"
+ end
+ end.new("ok", 10)
+ raise "[Bug #17033]", cause: exc
+ end;
+ assert_equal(1, errs.count {|m| m.include?("[Bug #17033]")}, proc {errs.pretty_inspect})
+ end
+ end
+
def test_anonymous_message
assert_in_out_err([], "raise Class.new(RuntimeError), 'foo'", [], /foo\n/)
end
diff --git a/version.h b/version.h
index 15007f2ee2..bc61b57af4 100644
--- a/version.h
+++ b/version.h
@@ -2,7 +2,7 @@
# define RUBY_VERSION_MINOR RUBY_API_VERSION_MINOR
#define RUBY_VERSION_TEENY 1
#define RUBY_RELEASE_DATE RUBY_RELEASE_YEAR_STR"-"RUBY_RELEASE_MONTH_STR"-"RUBY_RELEASE_DAY_STR
-#define RUBY_PATCHLEVEL 100
+#define RUBY_PATCHLEVEL 101
#define RUBY_RELEASE_YEAR 2020
#define RUBY_RELEASE_MONTH 7