diff options
| author | Yusuke Endoh <mame@ruby-lang.org> | 2020-02-09 11:04:53 +0900 |
|---|---|---|
| committer | nagachika <nagachika@ruby-lang.org> | 2020-09-09 22:47:58 +0900 |
| commit | 3590f082442afc4506250f5274a7877371a112de (patch) | |
| tree | 529ea2fe951bd1087a98873f90b0db5c379262de | |
| parent | 277076173af868d297070da43fcb3a06ccb7e21f (diff) | |
| download | ruby-3590f082442afc4506250f5274a7877371a112de.tar.gz | |
spec/ruby/core/file/utime_spec.rb: far future timestamp may be trancated
Under some Ext4 filesystem settings, a timestamp is limited up to
0x37fffffff (2446-05-10).
https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout#Inode_Timestamps
> Therefore, timestamps should not overflow until May 2446.
Actually the spec fails under one of our CI environments, like:
```
1)
File.utime allows Time instances in the far future to set mtime and atime FAILED
Expected 2446 == 559444
to be truthy but was false
```
https://rubyci.org/logs/rubyci.s3.amazonaws.com/arch/ruby-master/log/20200208T180002Z.fail.html.gz
| -rw-r--r-- | spec/ruby/core/file/utime_spec.rb | 8 | ||||
| -rw-r--r-- | version.h | 4 |
2 files changed, 7 insertions, 5 deletions
diff --git a/spec/ruby/core/file/utime_spec.rb b/spec/ruby/core/file/utime_spec.rb index 03adc76efe..9c198af18b 100644 --- a/spec/ruby/core/file/utime_spec.rb +++ b/spec/ruby/core/file/utime_spec.rb @@ -72,11 +72,13 @@ describe "File.utime" do platform_is :linux do platform_is wordsize: 64 do - it "allows Time instances in the far future to set mtime and atime" do + it "allows Time instances in the far future to set mtime and atime (but some filesystems limit it up to 2446-05-10)" do + # https://ext4.wiki.kernel.org/index.php/Ext4_Disk_Layout#Inode_Timestamps + # "Therefore, timestamps should not overflow until May 2446." time = Time.at(1<<44) File.utime(time, time, @file1) - File.atime(@file1).year.should == 559444 - File.mtime(@file1).year.should == 559444 + [559444, 2446].should.include? File.atime(@file1).year + [559444, 2446].should.include? File.mtime(@file1).year end end end @@ -2,11 +2,11 @@ # define RUBY_VERSION_MINOR RUBY_API_VERSION_MINOR #define RUBY_VERSION_TEENY 1 #define RUBY_RELEASE_DATE RUBY_RELEASE_YEAR_STR"-"RUBY_RELEASE_MONTH_STR"-"RUBY_RELEASE_DAY_STR -#define RUBY_PATCHLEVEL 123 +#define RUBY_PATCHLEVEL 124 #define RUBY_RELEASE_YEAR 2020 #define RUBY_RELEASE_MONTH 9 -#define RUBY_RELEASE_DAY 7 +#define RUBY_RELEASE_DAY 9 #include "ruby/version.h" |