diff options
author | mame <mame@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2019-01-01 01:47:14 +0000 |
---|---|---|
committer | mame <mame@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2019-01-01 01:47:14 +0000 |
commit | 4130969ea19835d0a69a69ee6ffc7fa3dfedb675 (patch) | |
tree | 2a25320ec10245b480db9af9766e4a97c8acc92d | |
parent | 04dec2df733a7ca1cf895be3e82ad3b0cf374741 (diff) | |
download | ruby-4130969ea19835d0a69a69ee6ffc7fa3dfedb675.tar.gz |
Revert r66670 because of wrong ticket number
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@66672 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | compile.c | 18 | ||||
-rw-r--r-- | test/coverage/test_coverage.rb | 17 |
2 files changed, 9 insertions, 26 deletions
@@ -7462,10 +7462,8 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in DECL_ANCHOR(args); unsigned int flag = 0; ID mid = node->nd_mid; - LABEL *else_label = 0; - LABEL *end_label = 0; + LABEL *lskip = 0; VALUE argc; - VALUE branches = 0; /* optimization shortcut * obj["literal"] = value -> opt_aset_with(obj, "literal", value) @@ -7505,11 +7503,8 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in /* safe nav attr */ mid = rb_id_attrset(mid); ADD_INSN(recv, line, dup); - else_label = NEW_LABEL(line); - end_label = NEW_LABEL(line); - DECL_BRANCH_BASE(branches, nd_first_lineno(node), nd_first_column(node), nd_last_lineno(node), nd_last_column(node), "&."); - ADD_INSNL(recv, line, branchnil, else_label); - ADD_TRACE_BRANCH_COVERAGE(recv, nd_first_lineno(node), nd_first_column(node), nd_last_lineno(node), nd_last_column(node), "then", branches); + lskip = NEW_LABEL(line); + ADD_INSNL(recv, line, branchnil, lskip); } if (!popped) { ADD_INSN(ret, line, putnil); @@ -7541,12 +7536,7 @@ iseq_compile_each0(rb_iseq_t *iseq, LINK_ANCHOR *const ret, const NODE *node, in ADD_SEQ(ret, args); } ADD_SEND_WITH_FLAG(ret, line, mid, argc, INT2FIX(flag)); - if (else_label && end_label) { - ADD_INSNL(ret, line, jump, end_label); - ADD_LABEL(ret, else_label); - ADD_TRACE_BRANCH_COVERAGE(ret, nd_first_lineno(node), nd_first_column(node), nd_last_lineno(node), nd_last_column(node), "else", branches); - ADD_LABEL(ret, end_label); - } + if (lskip) ADD_LABEL(ret, lskip); ADD_INSN(ret, line, pop); break; diff --git a/test/coverage/test_coverage.rb b/test/coverage/test_coverage.rb index 1797c898af..d2a2d018a9 100644 --- a/test/coverage/test_coverage.rb +++ b/test/coverage/test_coverage.rb @@ -348,22 +348,15 @@ class TestCoverage < Test::Unit::TestCase def test_branch_coverage_for_safe_method_invocation result = { :branches=>{ - [:"&.", 0, 6, 0, 6, 6] => {[:then, 1, 6, 0, 6, 6]=>1, [:else, 2, 6, 0, 6, 6]=>0}, - [:"&.", 3, 7, 0, 7, 6] => {[:then, 4, 7, 0, 7, 6]=>0, [:else, 5, 7, 0, 7, 6]=>1}, - [:"&.", 6, 8, 0, 8, 10] => {[:then, 7, 8, 0, 8, 10]=>1, [:else, 8, 8, 0, 8, 10]=>0}, - [:"&.", 9, 9, 0, 9, 10] => {[:then, 10, 9, 0, 9, 10]=>0, [:else, 11, 9, 0, 9, 10]=>1}, + [:"&.", 0, 3, 0, 3, 6] => {[:then, 1, 3, 0, 3, 6]=>1, [:else, 2, 3, 0, 3, 6]=>0}, + [:"&.", 3, 4, 0, 4, 6] => {[:then, 4, 4, 0, 4, 6]=>0, [:else, 5, 4, 0, 4, 6]=>1}, } } assert_coverage(<<~"end;", { branches: true }, result) - class Dummy; def foo; end; def foo=(x); end; end - a = Dummy.new + a = 10 b = nil - c = Dummy.new - d = nil - a&.foo - b&.foo - c&.foo = 1 - d&.foo = 1 + a&.abs + b&.hoo end; end |