diff options
author | Vít Ondruch <vondruch@redhat.com> | 2019-10-01 12:25:07 +0200 |
---|---|---|
committer | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2020-02-26 11:04:52 +0900 |
commit | 6609940a5e5c46dcc96d2bd3c228a951df6240ce (patch) | |
tree | bdc6098bed021dfb7ee670189439941fa02b48ca | |
parent | e960ef6f18a25c637c54f00c75bb6c24f8ab55d0 (diff) | |
download | ruby-6609940a5e5c46dcc96d2bd3c228a951df6240ce.tar.gz |
Use `$script_mode` instead of `$prog_mode` for gem inistallation.
rbinstall is using `$script_mode` and `$prog_mode`. However, the
`$script_mode` fallbacks to `$prog_mode` if not provided.
However, RubyGems do not distinguish between `$script_mode` and
`$prog_mode`:
https://github.com/rubygems/rubygems/blame/92892bbc3adba86a90756c385433835f6761b8da/lib/rubygems/installer.rb#L196
https://github.com/rubygems/rubygems/blame/92892bbc3adba86a90756c385433835f6761b8da/lib/rubygems/installer.rb#L515
https://github.com/rubygems/rubygems/blame/92892bbc3adba86a90756c385433835f6761b8da/lib/rubygems/installer.rb#L543
Comparing the usage of `$script_mode` and `$prog_mode`, it seems that
the `$script_mode` should be used where RubyGems expects `$prog_mode`.
-rwxr-xr-x | tool/rbinstall.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tool/rbinstall.rb b/tool/rbinstall.rb index 7fc0109923..fbf818fe34 100755 --- a/tool/rbinstall.rb +++ b/tool/rbinstall.rb @@ -877,7 +877,7 @@ install?(:ext, :comm, :gem, :'bundled-gems') do :ignore_dependencies => true, :dir_mode => $dir_mode, :data_mode => $data_mode, - :prog_mode => $prog_mode, + :prog_mode => $script_mode, :wrappers => true, :format_executable => true, } |