diff options
author | Utkarsh Gupta <utkarsh@debian.org> | 2020-06-19 16:14:18 +0530 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-07-15 16:05:12 +0900 |
commit | 3b0d2a3d6ddd4f3d361e15af96881275e8923a5e (patch) | |
tree | 5b6b5fad9de78ab0b8096ebe866ec4eabb5760ce | |
parent | 2b73f26fdefc88d25daf0d712105f4340c239062 (diff) | |
download | ruby-3b0d2a3d6ddd4f3d361e15af96881275e8923a5e.tar.gz |
[rubygems/rubygems] Fix RuboCop offenses
These offenses appear when you create a gem with
`bundle gem foo` and run `rubocop` over it.
Initially, there were around 45 offenses detected,
but with #3731 and this, the number of offenses
have been reduced to 2.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
https://github.com/rubygems/rubygems/commit/fe9dcaa1b4
-rw-r--r-- | lib/bundler/templates/newgem/Gemfile.tt | 2 | ||||
-rw-r--r-- | lib/bundler/templates/newgem/Rakefile.tt | 4 | ||||
-rw-r--r-- | lib/bundler/templates/newgem/bin/console.tt | 2 | ||||
-rw-r--r-- | lib/bundler/templates/newgem/lib/newgem.rb.tt | 2 | ||||
-rw-r--r-- | lib/bundler/templates/newgem/lib/newgem/version.rb.tt | 2 | ||||
-rw-r--r-- | lib/bundler/templates/newgem/newgem.gemspec.tt | 10 | ||||
-rw-r--r-- | lib/bundler/templates/newgem/spec/newgem_spec.rb.tt | 2 | ||||
-rw-r--r-- | lib/bundler/templates/newgem/spec/spec_helper.rb.tt | 2 |
8 files changed, 20 insertions, 6 deletions
diff --git a/lib/bundler/templates/newgem/Gemfile.tt b/lib/bundler/templates/newgem/Gemfile.tt index b689e2e804..c6af5e8bfa 100644 --- a/lib/bundler/templates/newgem/Gemfile.tt +++ b/lib/bundler/templates/newgem/Gemfile.tt @@ -1,3 +1,5 @@ +# frozen_string_literal: true + source "https://rubygems.org" # Specify your gem's dependencies in <%= config[:name] %>.gemspec diff --git a/lib/bundler/templates/newgem/Rakefile.tt b/lib/bundler/templates/newgem/Rakefile.tt index af7729c04e..46bb01c7f8 100644 --- a/lib/bundler/templates/newgem/Rakefile.tt +++ b/lib/bundler/templates/newgem/Rakefile.tt @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "bundler/gem_tasks" <% default_task_names = [config[:test_task]].compact -%> <% case config[:test] -%> @@ -27,7 +29,7 @@ RuboCop::RakeTask.new <% default_task_names.unshift(:clobber, :compile) -%> require "rake/extensiontask" -task :build => :compile +task build: :compile Rake::ExtensionTask.new("<%= config[:underscored_name] %>") do |ext| ext.lib_dir = "lib/<%= config[:namespaced_path] %>" diff --git a/lib/bundler/templates/newgem/bin/console.tt b/lib/bundler/templates/newgem/bin/console.tt index a27f82430f..6378a5abce 100644 --- a/lib/bundler/templates/newgem/bin/console.tt +++ b/lib/bundler/templates/newgem/bin/console.tt @@ -1,3 +1,5 @@ +# frozen_string_literal: true + #!/usr/bin/env ruby require "bundler/setup" diff --git a/lib/bundler/templates/newgem/lib/newgem.rb.tt b/lib/bundler/templates/newgem/lib/newgem.rb.tt index fae6337c3e..a182b964be 100644 --- a/lib/bundler/templates/newgem/lib/newgem.rb.tt +++ b/lib/bundler/templates/newgem/lib/newgem.rb.tt @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "<%= config[:namespaced_path] %>/version" <%- if config[:ext] -%> require "<%= config[:namespaced_path] %>/<%= config[:underscored_name] %>" diff --git a/lib/bundler/templates/newgem/lib/newgem/version.rb.tt b/lib/bundler/templates/newgem/lib/newgem/version.rb.tt index 389daf5048..b5cd4cb232 100644 --- a/lib/bundler/templates/newgem/lib/newgem/version.rb.tt +++ b/lib/bundler/templates/newgem/lib/newgem/version.rb.tt @@ -1,3 +1,5 @@ +# frozen_string_literal: true + <%- config[:constant_array].each_with_index do |c, i| -%> <%= " " * i %>module <%= c %> <%- end -%> diff --git a/lib/bundler/templates/newgem/newgem.gemspec.tt b/lib/bundler/templates/newgem/newgem.gemspec.tt index 7961ccf24c..948de2d5e7 100644 --- a/lib/bundler/templates/newgem/newgem.gemspec.tt +++ b/lib/bundler/templates/newgem/newgem.gemspec.tt @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative "lib/<%=config[:namespaced_path]%>/version" Gem::Specification.new do |spec| @@ -6,8 +8,8 @@ Gem::Specification.new do |spec| spec.authors = [<%= config[:author].inspect %>] spec.email = [<%= config[:email].inspect %>] - spec.summary = %q{TODO: Write a short summary, because RubyGems requires one.} - spec.description = %q{TODO: Write a longer description or delete this line.} + spec.summary = "TODO: Write a short summary, because RubyGems requires one." + spec.description = "TODO: Write a longer description or delete this line." spec.homepage = "TODO: Put your gem's website or public repo URL here." <%- if config[:mit] -%> spec.license = "MIT" @@ -22,9 +24,7 @@ Gem::Specification.new do |spec| # Specify which files should be added to the gem when it is released. # The `git ls-files -z` loads the files in the RubyGem that have been added into git. - spec.files = Dir.chdir(File.expand_path("..", __FILE__)) do - `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } - end + spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } spec.bindir = "exe" spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] diff --git a/lib/bundler/templates/newgem/spec/newgem_spec.rb.tt b/lib/bundler/templates/newgem/spec/newgem_spec.rb.tt index c63b487830..82cada988c 100644 --- a/lib/bundler/templates/newgem/spec/newgem_spec.rb.tt +++ b/lib/bundler/templates/newgem/spec/newgem_spec.rb.tt @@ -1,3 +1,5 @@ +# frozen_string_literal: true + RSpec.describe <%= config[:constant_name] %> do it "has a version number" do expect(<%= config[:constant_name] %>::VERSION).not_to be nil diff --git a/lib/bundler/templates/newgem/spec/spec_helper.rb.tt b/lib/bundler/templates/newgem/spec/spec_helper.rb.tt index 805cf57e01..0bb8e6f165 100644 --- a/lib/bundler/templates/newgem/spec/spec_helper.rb.tt +++ b/lib/bundler/templates/newgem/spec/spec_helper.rb.tt @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "bundler/setup" require "<%= config[:namespaced_path] %>" |