diff options
author | nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-07-15 08:29:03 +0000 |
---|---|---|
committer | nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-07-15 08:29:03 +0000 |
commit | 1b27045a1514218140f0cecb0e928f2f2a9a4194 (patch) | |
tree | c1673a07e0d1ae963a963b77e221ca4724e00433 | |
parent | 781170cafa37e5e4b180f6d21a9a741c729e8c4b (diff) | |
download | ruby-1b27045a1514218140f0cecb0e928f2f2a9a4194.tar.gz |
parse.y: refine error messages
* parse.y (parser_read_escape, parser_tok_hex): refine error
messages. point from the backslash up to the invalid char.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59341 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-rw-r--r-- | parse.y | 7 | ||||
-rw-r--r-- | test/ruby/test_parse.rb | 14 |
2 files changed, 15 insertions, 6 deletions
@@ -5636,6 +5636,7 @@ parser_tok_hex(struct parser_params *parser, size_t *numlen) c = scan_hex(lex_p, 2, numlen); if (!*numlen) { + parser->tokp = lex_p; yyerror("invalid hex escape"); return 0; } @@ -5780,7 +5781,6 @@ parser_read_escape(struct parser_params *parser, int flags, case 'M': if (flags & ESCAPE_META) goto eof; if ((c = nextc()) != '-') { - pushback(c); goto eof; } if ((c = nextc()) == '\\') { @@ -5794,7 +5794,6 @@ parser_read_escape(struct parser_params *parser, int flags, case 'C': if ((c = nextc()) != '-') { - pushback(c); goto eof; } case 'c': @@ -5811,6 +5810,7 @@ parser_read_escape(struct parser_params *parser, int flags, eof: case -1: yyerror("Invalid escape character syntax"); + pushback(c); return '\0'; default: @@ -6045,6 +6045,9 @@ parser_tokadd_string(struct parser_params *parser, } else if (c == '\\') { const char *beg = lex_p - 1; +#ifndef RIPPER + parser->tokp = beg; +#endif c = nextc(); switch (c) { case '\n': diff --git a/test/ruby/test_parse.rb b/test/ruby/test_parse.rb index d6850f4bfd..46d9470287 100644 --- a/test/ruby/test_parse.rb +++ b/test/ruby/test_parse.rb @@ -484,21 +484,27 @@ class TestParse < Test::Unit::TestCase end def test_string - assert_raise(SyntaxError) do + mesg = 'from the backslash through the invalid char' + + e = assert_raise_with_message(SyntaxError, /hex escape/) do eval '"\xg1"' end + assert_equal(' ^', e.message.lines.last, mesg) - assert_raise(SyntaxError) do + e = assert_raise(SyntaxError) do eval '"\u{1234"' end + assert_match(' ^~~~~~~', e.message.lines.last, mesg) - assert_raise(SyntaxError) do + e = assert_raise_with_message(SyntaxError, /escape character syntax/) do eval '"\M1"' end + assert_equal(' ^~~', e.message.lines.last, mesg) - assert_raise(SyntaxError) do + e = assert_raise_with_message(SyntaxError, /escape character syntax/) do eval '"\C1"' end + assert_equal(' ^~~', e.message.lines.last, mesg) assert_equal("\x81", eval('"\C-\M-a"')) assert_equal("\177", eval('"\c?"')) |