diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-08-16 12:08:22 +0200 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2019-09-18 18:26:32 +0900 |
commit | a29ead52e169cf702a61ba91cdf301a3bd87d713 (patch) | |
tree | 3d77e06b11b76f5627b3b77440ad5904e3fa32e6 | |
parent | 9118cb242b141c380a0180f64ffeb0c9fdae0c8b (diff) | |
download | ruby-a29ead52e169cf702a61ba91cdf301a3bd87d713.tar.gz |
[bundler/bundler] Deprecate `--path` flag to `bundle check`
https://github.com/bundler/bundler/commit/0a0e7cf5ec
-rw-r--r-- | lib/bundler/cli.rb | 2 | ||||
-rw-r--r-- | spec/bundler/other/major_deprecation_spec.rb | 22 |
2 files changed, 24 insertions, 0 deletions
diff --git a/lib/bundler/cli.rb b/lib/bundler/cli.rb index 661985d6e2..9dadbece64 100644 --- a/lib/bundler/cli.rb +++ b/lib/bundler/cli.rb @@ -156,6 +156,8 @@ module Bundler "Specify a different path than the system default ($BUNDLE_PATH or $GEM_HOME).#{" Bundler will remember this value for future installs on this machine" unless Bundler.feature_flag.forget_cli_options?}" map "c" => "check" def check + remembered_flag_deprecation("path") + require_relative "cli/check" Check.new(options).run end diff --git a/spec/bundler/other/major_deprecation_spec.rb b/spec/bundler/other/major_deprecation_spec.rb index 2a819c907c..ee153a8e7c 100644 --- a/spec/bundler/other/major_deprecation_spec.rb +++ b/spec/bundler/other/major_deprecation_spec.rb @@ -95,6 +95,28 @@ RSpec.describe "major deprecations" do end end + context "bundle check --path" do + before do + install_gemfile <<-G + source "#{file_uri_for(gem_repo1)}" + gem "rack" + G + + bundle "check --path vendor/bundle" + end + + it "should print a deprecation warning", :bundler => "2" do + expect(deprecations).to include( + "The `--path` flag is deprecated because it relies on being " \ + "remembered accross bundler invokations, which bundler will no " \ + "longer do in future versions. Instead please use `bundle config set " \ + "path 'vendor/bundle'`, and stop using this flag" + ) + end + + pending "should fail with a helpful error", :bundler => "3" + end + describe "bundle config" do describe "old list interface" do before do |