aboutsummaryrefslogtreecommitdiffstats
path: root/cont.c
diff options
context:
space:
mode:
authorSamuel Williams <samuel.williams@oriontransfer.co.nz>2019-07-16 16:11:55 +1200
committerSamuel Williams <samuel.williams@oriontransfer.co.nz>2019-07-18 20:54:55 +1200
commit001f187ed6539f320421d8893d2f3c8f584cc3a5 (patch)
treece525733ca95a920083874cc50ee47084f1e687a /cont.c
parent385ea910fc28f0e46c72669a260e44d4f3f37d9e (diff)
downloadruby-001f187ed6539f320421d8893d2f3c8f584cc3a5.tar.gz
Make fiber_pool more conservative on platforms with limited address space.
We use COROUTINE_LIMITED_ADDRESS_SPACE to select platforms where address space is 32-bits or less. Fiber pool implementation enables more book keeping, and reduces upper limits, in order to minimise address space utilisation.
Diffstat (limited to 'cont.c')
-rw-r--r--cont.c24
1 files changed, 12 insertions, 12 deletions
diff --git a/cont.c b/cont.c
index 16e8d7c33d..25fb62354a 100644
--- a/cont.c
+++ b/cont.c
@@ -37,7 +37,16 @@ static VALUE rb_cFiberPool;
#endif
#define CAPTURE_JUST_VALID_VM_STACK 1
-//#define FIBER_POOL_ALLOCATION_FREE
+
+// Defined in `coroutine/$arch/Context.h`:
+#ifdef COROUTINE_LIMITED_ADDRESS_SPACE
+#define FIBER_POOL_ALLOCATION_FREE
+#define FIBER_POOL_INITIAL_SIZE 8
+#define FIBER_POOL_ALLOCATION_MAXIMUM_SIZE 32
+#else
+#define FIBER_POOL_INITIAL_SIZE 32
+#define FIBER_POOL_ALLOCATION_MAXIMUM_SIZE 4096
+#endif
enum context_type {
CONTINUATION_CONTEXT = 0,
@@ -461,15 +470,6 @@ fiber_pool_expand(struct fiber_pool * fiber_pool, size_t count)
return allocation;
}
-static inline size_t
-fiber_pool_default_allocation_count_limit() {
- if (sizeof(void*) <= 4) {
- return 32;
- } else {
- return 1024;
- }
-}
-
// Initialize the specified fiber pool with the given number of stacks.
// @param vm_stack_size The size of the vm stack to allocate.
static void
@@ -542,7 +542,7 @@ fiber_pool_stack_acquire(struct fiber_pool * fiber_pool) {
if (DEBUG) fprintf(stderr, "fiber_pool_stack_acquire: %p used=%zu\n", fiber_pool->vacancies, fiber_pool->used);
if (!vacancy) {
- const size_t maximum = fiber_pool_default_allocation_count_limit();
+ const size_t maximum = FIBER_POOL_ALLOCATION_MAXIMUM_SIZE;
const size_t minimum = fiber_pool->initial_count;
size_t count = fiber_pool->count;
@@ -2335,7 +2335,7 @@ Init_Cont(void)
#endif
SET_MACHINE_STACK_END(&th->ec->machine.stack_end);
- fiber_pool_initialize(&shared_fiber_pool, stack_size, 8, vm_stack_size);
+ fiber_pool_initialize(&shared_fiber_pool, stack_size, FIBER_POOL_INITIAL_SIZE, vm_stack_size);
rb_cFiber = rb_define_class("Fiber", rb_cObject);
rb_define_alloc_func(rb_cFiber, fiber_alloc);