aboutsummaryrefslogtreecommitdiffstats
path: root/eval.c
diff options
context:
space:
mode:
authornobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-04-17 02:31:35 +0000
committernobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-04-17 02:31:35 +0000
commitbf8f8a0ec1e75200f4217e4715cd9d1f45140c90 (patch)
treeccaa98da5509c2fd002552b13e7cfb7973f4fa69 /eval.c
parent70f17dfbcc4395b59dd3b4e809059591ac3e1049 (diff)
downloadruby-bf8f8a0ec1e75200f4217e4715cd9d1f45140c90.tar.gz
eval.c: copy special exceptions before raise
* eval.c (setup_exception): consider if the exception is frozen, but not one of special exception objects. * gc.c (rb_memerror): copy minimum objects. * thread.c (rb_threadptr_execute_interrupts): prepare special exception queued by another thread to be raised. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'eval.c')
-rw-r--r--eval.c58
1 files changed, 14 insertions, 44 deletions
diff --git a/eval.c b/eval.c
index f3c151a130..7f500b8d64 100644
--- a/eval.c
+++ b/eval.c
@@ -464,23 +464,6 @@ exc_setup_cause(VALUE exc, VALUE cause)
return exc;
}
-static inline int
-sysstack_error_p(VALUE exc)
-{
- return exc == sysstack_error || (!SPECIAL_CONST_P(exc) && RBASIC_CLASS(exc) == rb_eSysStackError);
-}
-
-static inline int
-special_exception_p(rb_thread_t *th, VALUE exc)
-{
- enum ruby_special_exceptions i;
- const VALUE *exceptions = th->vm->special_exceptions;
- for (i = 0; i < ruby_special_error_count; ++i) {
- if (exceptions[i] == exc) return TRUE;
- }
- return FALSE;
-}
-
static void
setup_exception(rb_thread_t *th, int tag, volatile VALUE mesg, VALUE cause)
{
@@ -498,9 +481,6 @@ setup_exception(rb_thread_t *th, int tag, volatile VALUE mesg, VALUE cause)
mesg = rb_exc_new(rb_eRuntimeError, 0, 0);
nocause = 0;
}
- else if (special_exception_p(th, mesg)) {
- mesg = ruby_vm_special_exception_copy(mesg);
- }
if (cause != Qundef) {
exc_setup_cause(mesg, cause);
}
@@ -514,33 +494,24 @@ setup_exception(rb_thread_t *th, int tag, volatile VALUE mesg, VALUE cause)
file = rb_source_loc(&line);
if (file && !NIL_P(mesg)) {
VALUE at;
- if (sysstack_error_p(mesg)) {
- if (NIL_P(rb_attr_get(mesg, idBt))) {
+ int status;
+
+ TH_PUSH_TAG(th);
+ if ((status = EXEC_TAG()) == 0) {
+ VALUE bt;
+ if (rb_threadptr_set_raised(th)) goto fatal;
+ bt = rb_get_backtrace(mesg);
+ if (NIL_P(bt)) {
at = rb_threadptr_backtrace_object(th);
- rb_ivar_set(mesg, idBt, at);
- rb_ivar_set(mesg, idBt_locations, at);
- }
- }
- else {
- int status;
-
- TH_PUSH_TAG(th);
- if ((status = EXEC_TAG()) == 0) {
- VALUE bt;
- if (rb_threadptr_set_raised(th)) goto fatal;
- bt = rb_get_backtrace(mesg);
- if (NIL_P(bt)) {
- at = rb_threadptr_backtrace_object(th);
- if (OBJ_FROZEN(mesg)) {
- mesg = rb_obj_dup(mesg);
- }
- rb_ivar_set(mesg, idBt_locations, at);
- set_backtrace(mesg, at);
+ if (OBJ_FROZEN(mesg)) {
+ mesg = rb_obj_dup(mesg);
}
- rb_threadptr_reset_raised(th);
+ rb_ivar_set(mesg, idBt_locations, at);
+ set_backtrace(mesg, at);
}
- TH_POP_TAG();
+ rb_threadptr_reset_raised(th);
}
+ TH_POP_TAG();
}
if (!NIL_P(mesg)) {
@@ -738,7 +709,6 @@ make_exception(int argc, const VALUE *argv, int isstr)
exc = argv[0];
n = 1;
exception_call:
- if (sysstack_error_p(exc)) return exc;
mesg = rb_check_funcall(exc, idException, n, argv+1);
if (mesg == Qundef) {
rb_raise(rb_eTypeError, "exception class/object expected");