aboutsummaryrefslogtreecommitdiffstats
path: root/ext
diff options
context:
space:
mode:
authorKoichi Sasada <ko1@atdot.net>2019-12-04 13:36:41 +0900
committerKoichi Sasada <ko1@atdot.net>2019-12-04 13:36:41 +0900
commitc6e3db0c66312af1e932c21006437419efa9ac75 (patch)
treeb016c716a577fdd024a397a87e2eb715fb40586e /ext
parentf9e5c74cd24025a5aa19e318e8fecabf207f1b7b (diff)
downloadruby-c6e3db0c66312af1e932c21006437419efa9ac75.tar.gz
new_cond before mon_initialize
MonitorMixin#new_cond can be called before mon_initialize, so we need to initialize `@monitor` before it. https://bugs.ruby-lang.org/issues/16255#note-4
Diffstat (limited to 'ext')
-rw-r--r--ext/monitor/lib/monitor.rb12
1 files changed, 10 insertions, 2 deletions
diff --git a/ext/monitor/lib/monitor.rb b/ext/monitor/lib/monitor.rb
index 821dccadbe..1883cb72f6 100644
--- a/ext/monitor/lib/monitor.rb
+++ b/ext/monitor/lib/monitor.rb
@@ -208,6 +208,10 @@ module MonitorMixin
# Monitor object.
#
def new_cond
+ unless defined?(@mon_data)
+ mon_initialize
+ @mon_initialized_by_new_cond = true
+ end
return ConditionVariable.new(@mon_data)
end
@@ -224,8 +228,12 @@ module MonitorMixin
# Initializes the MonitorMixin after being included in a class or when an
# object has been extended with the MonitorMixin
def mon_initialize
- if defined?(@mon_data) && @mon_data_owner_object_id == self.object_id
- raise ThreadError, "already initialized"
+ if defined?(@mon_data)
+ if defined?(@mon_initialized_by_new_cond)
+ return # already initalized.
+ elsif @mon_data_owner_object_id == self.object_id
+ raise ThreadError, "already initialized"
+ end
end
@mon_data = ::Monitor.new
@mon_data_owner_object_id = self.object_id