diff options
author | Takashi Kokubun <takashikkbn@gmail.com> | 2019-10-13 09:59:43 -0700 |
---|---|---|
committer | Takashi Kokubun <takashikkbn@gmail.com> | 2019-10-13 09:59:44 -0700 |
commit | 26fae9aa9db59fdee7422a276662b45611e98a22 (patch) | |
tree | 29818422ea540f33f106abe26c29d50b73aff122 /mjit.c | |
parent | 6a1809e2e1a95c14cfb72701df480e3ebccd4b24 (diff) | |
download | ruby-26fae9aa9db59fdee7422a276662b45611e98a22.tar.gz |
Remove the quick stop path after convert_unit_to_func
Now I'm not exactly sure why I needed to check `stop_worker_p` after
`mjit_copy_cache_from_main_thread` of `convert_unit_to_func`
in 4161674b2fbea6bdd01783ac5d3b39d88db22972.
If it's for avoiding deadlock under `in_gc` condition, we should keep it.
However, if it's not the case and it's just for retrying accidental
compilation failure or just to avoid `MJIT_ATOMIC_SET` and
`compact_all_jit_code`, I think this quick stop path is not mandatory.
Because this path is somewhat problematic in my upcoming fix in
mjit_worker, let me try to remove this first and see how CI goes.
Diffstat (limited to 'mjit.c')
-rw-r--r-- | mjit.c | 2 |
1 files changed, 0 insertions, 2 deletions
@@ -802,9 +802,7 @@ mjit_pause(bool wait_p) } } - mjit_pause_wait_p = wait_p; // Avoid cancelling the last compilation after the unit fetch if wait_p. stop_worker(); - mjit_pause_wait_p = false; return Qtrue; } |