diff options
author | shyouhei <shyouhei@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-03-06 11:14:05 +0000 |
---|---|---|
committer | shyouhei <shyouhei@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-03-06 11:14:05 +0000 |
commit | 42fe57d41b6a317d31f817f75e04851281e27750 (patch) | |
tree | 148c82adfc714aaa2a3d60cda2c18c4f78ed9f76 /object.c | |
parent | c24d87191f249ef8fdd363226dce2fd67475079c (diff) | |
download | ruby-42fe57d41b6a317d31f817f75e04851281e27750.tar.gz |
optimize FIXABLE macro
Looking at the source code, FIXABLE tends to be just before LOING2FIX
to check applicability of that operation. Why not try computing first
then check for overflow, which should be optimial.
I also tried the same thing for unsigned types but resulted in slower
execution. It seems RB_POSFIXABLE() is fast enough on modern CPUs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57789 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'object.c')
-rw-r--r-- | object.c | 5 |
1 files changed, 1 insertions, 4 deletions
@@ -2747,11 +2747,8 @@ rb_convert_to_integer(VALUE val, int base) VALUE tmp; if (RB_FLOAT_TYPE_P(val)) { - double f; if (base != 0) goto arg_error; - f = RFLOAT_VALUE(val); - if (FIXABLE(f)) return LONG2FIX((long)f); - return rb_dbl2big(f); + return rb_dbl2ival(RFLOAT_VALUE(val)); } else if (RB_INTEGER_TYPE_P(val)) { if (base != 0) goto arg_error; |