Fully separate positional arguments and keyword arguments

This removes the warnings added in 2.7, and changes the behavior
so that a final positional hash is not treated as keywords or
vice-versa.

To handle the arg_setup_block splat case correctly with keyword
arguments, we need to check if we are taking a keyword hash.
That case didn't have a test, but it affects real-world code,
so add a test for it.

This removes rb_empty_keyword_given_p() and related code, as
that is not needed in Ruby 3.  The empty keyword case is the
same as the no keyword case in Ruby 3.

This changes rb_scan_args to implement keyword argument
separation for C functions when the : character is used.
For backwards compatibility, it returns a duped hash.
This is a bad idea for performance, but not duping the hash
breaks at least Enumerator::ArithmeticSequence#inspect.

Instead of having RB_PASS_CALLED_KEYWORDS be a number,
simplify the code by just making it be rb_keyword_given_p().

1 files changed, 0 insertions, 5 deletions

diff --git a/proc.c b/proc.c
index 7094a021f3..5434e8daa7 100644
--- a/proc.c
+++ b/proc.c
@@ -955,14 +955,11 @@ rb_proc_call_kw(VALUE self, VALUE args, int kw_splat)
 {
     VALUE vret;
     rb_proc_t *proc;
-    VALUE v;
     int argc = check_argc(RARRAY_LEN(args));
     const VALUE *argv = RARRAY_CONST_PTR(args);
     GetProcPtr(self, proc);
-    v = rb_adjust_argv_kw_splat(&argc, &argv, &kw_splat);
     vret = rb_vm_invoke_proc(GET_EC(), proc, argc, argv,
                              kw_splat, VM_BLOCK_HANDLER_NONE);
-    rb_free_tmp_buffer(&v);
     RB_GC_GUARD(self);
     RB_GC_GUARD(args);
     return vret;
@@ -994,10 +991,8 @@ rb_proc_call_with_block_kw(VALUE self, int argc, const VALUE *argv, VALUE passed
     rb_execution_context_t *ec = GET_EC();
     VALUE vret;
     rb_proc_t *proc;
-    VALUE v = rb_adjust_argv_kw_splat(&argc, &argv, &kw_splat);
     GetProcPtr(self, proc);
     vret = rb_vm_invoke_proc(ec, proc, argc, argv, kw_splat, proc_to_block_handler(passed_procval));
-    rb_free_tmp_buffer(&v);
     RB_GC_GUARD(self);
     return vret;
 }