aboutsummaryrefslogtreecommitdiffstats
path: root/process.c
diff options
context:
space:
mode:
authorNobuyoshi Nakada <nobu@ruby-lang.org>2020-02-11 15:52:25 +0900
committerNobuyoshi Nakada <nobu@ruby-lang.org>2020-02-11 15:55:10 +0900
commitde3883e7823c89ce90d7661ef5bb3b7eb60968db (patch)
tree45e1cf0487be4a6d514eb59e37542f1805c72748 /process.c
parentf905f694ccc1f97c77af78d8d7881aa7c9ddabd3 (diff)
downloadruby-de3883e7823c89ce90d7661ef5bb3b7eb60968db.tar.gz
Restart timer thread even after preparation failed
If the timer thread is left stopped, memory crash or segfault can happen.
Diffstat (limited to 'process.c')
-rw-r--r--process.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/process.c b/process.c
index bb895150d8..725ab0da5b 100644
--- a/process.c
+++ b/process.c
@@ -2905,13 +2905,20 @@ rb_f_exec(int argc, const VALUE *argv)
struct rb_execarg *eargp;
#define CHILD_ERRMSG_BUFLEN 80
char errmsg[CHILD_ERRMSG_BUFLEN] = { '\0' };
- int err;
+ int err, state;
execarg_obj = rb_execarg_new(argc, argv, TRUE, FALSE);
eargp = rb_execarg_get(execarg_obj);
if (mjit_enabled) mjit_finish(false); // avoid leaking resources, and do not leave files. XXX: JIT-ed handle can leak after exec error is rescued.
before_exec(); /* stop timer thread before redirects */
- rb_execarg_parent_start(execarg_obj);
+
+ rb_protect(rb_execarg_parent_start1, execarg_obj, &state);
+ if (state) {
+ execarg_parent_end(execarg_obj);
+ after_exec(); /* restart timer thread */
+ rb_jump_tag(state);
+ }
+
fail_str = eargp->use_shell ? eargp->invoke.sh.shell_script : eargp->invoke.cmd.command_name;
err = exec_async_signal_safe(eargp, errmsg, sizeof(errmsg));