aboutsummaryrefslogtreecommitdiffstats
path: root/spec/bundler/commands
diff options
context:
space:
mode:
authorDavid Rodríguez <deivid.rodriguez@riseup.net>2019-06-17 10:23:47 +0200
committerHiroshi SHIBATA <hsbt@ruby-lang.org>2019-08-03 09:29:56 +0900
commitb014a2157f3b43d7ac85b27ad2cc47705487251e (patch)
tree965687fd2ef10c7fd045b23d673ceb90506a9b9a /spec/bundler/commands
parent10c0271f970d1133685d91e786cf25f7160ffd50 (diff)
downloadruby-b014a2157f3b43d7ac85b27ad2cc47705487251e.tar.gz
[bundler/bundler] Factor out gemspec call inside `let`
https://github.com/bundler/bundler/commit/ae0ac190aa
Diffstat (limited to 'spec/bundler/commands')
-rw-r--r--spec/bundler/commands/newgem_spec.rb16
1 files changed, 8 insertions, 8 deletions
diff --git a/spec/bundler/commands/newgem_spec.rb b/spec/bundler/commands/newgem_spec.rb
index defda99580..a63019c537 100644
--- a/spec/bundler/commands/newgem_spec.rb
+++ b/spec/bundler/commands/newgem_spec.rb
@@ -16,7 +16,7 @@ RSpec.describe "bundle gem" do
expect(bundled_app("#{gem_name}/lib/test/gem/version.rb")).to exist
end
- let(:generated_gem) { Bundler::GemHelper.new(bundled_app(gem_name).to_s) }
+ let(:generated_gemspec) { Bundler::GemHelper.new(bundled_app(gem_name).to_s).gemspec }
before do
global_config "BUNDLE_GEM__MIT" => "false", "BUNDLE_GEM__TEST" => "false", "BUNDLE_GEM__COC" => "false"
@@ -41,22 +41,22 @@ RSpec.describe "bundle gem" do
shared_examples_for "git config is present" do
context "git config user.{name,email} present" do
it "sets gemspec author to git user.name if available" do
- expect(generated_gem.gemspec.authors.first).to eq("Bundler User")
+ expect(generated_gemspec.authors.first).to eq("Bundler User")
end
it "sets gemspec email to git user.email if available" do
- expect(generated_gem.gemspec.email.first).to eq("user@example.com")
+ expect(generated_gemspec.email.first).to eq("user@example.com")
end
end
end
shared_examples_for "git config is absent" do
it "sets gemspec author to default message if git user.name is not set or empty" do
- expect(generated_gem.gemspec.authors.first).to eq("TODO: Write your name")
+ expect(generated_gemspec.authors.first).to eq("TODO: Write your name")
end
it "sets gemspec email to default message if git user.email is not set or empty" do
- expect(generated_gem.gemspec.email.first).to eq("TODO: Write your email address")
+ expect(generated_gemspec.email.first).to eq("TODO: Write your email address")
end
end
@@ -270,7 +270,7 @@ RSpec.describe "bundle gem" do
end
it "sets gemspec metadata['allowed_push_host']" do
- expect(generated_gem.gemspec.metadata["allowed_push_host"]).
+ expect(generated_gemspec.metadata["allowed_push_host"]).
to match(/mygemserver\.com/)
end
@@ -358,7 +358,7 @@ RSpec.describe "bundle gem" do
end
it "depends on a specific version of rspec" do
- rspec_dep = generated_gem.gemspec.development_dependencies.find {|d| d.name == "rspec" }
+ rspec_dep = generated_gemspec.development_dependencies.find {|d| d.name == "rspec" }
expect(rspec_dep).to be_specific
end
@@ -405,7 +405,7 @@ RSpec.describe "bundle gem" do
end
it "depends on a specific version of minitest" do
- rspec_dep = generated_gem.gemspec.development_dependencies.find {|d| d.name == "minitest" }
+ rspec_dep = generated_gemspec.development_dependencies.find {|d| d.name == "minitest" }
expect(rspec_dep).to be_specific
end