diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2020-06-24 19:52:14 +0200 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-07-15 16:05:12 +0900 |
commit | 16823d4a05580e041ff514122de5f3a3fbcef409 (patch) | |
tree | 56b01b2c04e7b89e4e7437db1e4abcc9ad7fde94 /spec/bundler/install | |
parent | e2837a77be2164fa17be046eabb93cbb63f77311 (diff) | |
download | ruby-16823d4a05580e041ff514122de5f3a3fbcef409.tar.gz |
[rubygems/rubygems] Remove unnecessary assertions on exitstatus
Since our helpers now raise by default if the subcommand fails, these
will never actually fail and are not necessary.
https://github.com/rubygems/rubygems/commit/6153b9321e
Diffstat (limited to 'spec/bundler/install')
-rw-r--r-- | spec/bundler/install/gemfile/git_spec.rb | 2 | ||||
-rw-r--r-- | spec/bundler/install/gemfile/path_spec.rb | 2 | ||||
-rw-r--r-- | spec/bundler/install/gemfile/platform_spec.rb | 1 | ||||
-rw-r--r-- | spec/bundler/install/gemfile/ruby_spec.rb | 1 | ||||
-rw-r--r-- | spec/bundler/install/gems/compact_index_spec.rb | 2 | ||||
-rw-r--r-- | spec/bundler/install/gems/dependency_api_spec.rb | 2 | ||||
-rw-r--r-- | spec/bundler/install/gems/win32_spec.rb | 1 | ||||
-rw-r--r-- | spec/bundler/install/security_policy_spec.rb | 4 |
8 files changed, 0 insertions, 15 deletions
diff --git a/spec/bundler/install/gemfile/git_spec.rb b/spec/bundler/install/gemfile/git_spec.rb index 81d234e101..aaef839c0a 100644 --- a/spec/bundler/install/gemfile/git_spec.rb +++ b/spec/bundler/install/gemfile/git_spec.rb @@ -912,7 +912,6 @@ RSpec.describe "bundle install with git sources" do bundle "install" bundle "install" - expect(exitstatus).to eq(0) if exitstatus end it "prints a friendly error if a file blocks the git repo" do @@ -1358,7 +1357,6 @@ In Gemfile: end G - expect(exitstatus).to eq(0) if exitstatus expect(ENV["GIT_DIR"]).to eq("bar") expect(ENV["GIT_WORK_TREE"]).to eq("bar") end diff --git a/spec/bundler/install/gemfile/path_spec.rb b/spec/bundler/install/gemfile/path_spec.rb index 29cbb291a4..84ece3d699 100644 --- a/spec/bundler/install/gemfile/path_spec.rb +++ b/spec/bundler/install/gemfile/path_spec.rb @@ -133,7 +133,6 @@ RSpec.describe "bundle install with explicit source paths" do bundle "config --local frozen true" bundle :install - expect(exitstatus).to eq(0) if exitstatus end it "installs dependencies from the path even if a newer gem is available elsewhere" do @@ -421,7 +420,6 @@ RSpec.describe "bundle install with explicit source paths" do install_gemfile <<-G gem "bar", "1.0.0", path: "vendor/bar", require: "bar/nyard" G - expect(exitstatus).to eq(0) if exitstatus end context "existing lockfile" do diff --git a/spec/bundler/install/gemfile/platform_spec.rb b/spec/bundler/install/gemfile/platform_spec.rb index 13b3e47163..dd58aef29b 100644 --- a/spec/bundler/install/gemfile/platform_spec.rb +++ b/spec/bundler/install/gemfile/platform_spec.rb @@ -349,7 +349,6 @@ RSpec.describe "bundle install with platform conditionals" do G bundle :list - expect(exitstatus).to eq(0) if exitstatus end it "does not attempt to install gems from :rbx when using --local" do diff --git a/spec/bundler/install/gemfile/ruby_spec.rb b/spec/bundler/install/gemfile/ruby_spec.rb index cdb3960089..fd4300c042 100644 --- a/spec/bundler/install/gemfile/ruby_spec.rb +++ b/spec/bundler/install/gemfile/ruby_spec.rb @@ -22,7 +22,6 @@ RSpec.describe "ruby requirement" do gem "rack-obama" G - expect(exitstatus).to eq(0) if exitstatus expect(the_bundle).to include_gems "rack-obama 1.0" end diff --git a/spec/bundler/install/gems/compact_index_spec.rb b/spec/bundler/install/gems/compact_index_spec.rb index 72b2f925d1..18c9485c3c 100644 --- a/spec/bundler/install/gems/compact_index_spec.rb +++ b/spec/bundler/install/gems/compact_index_spec.rb @@ -773,8 +773,6 @@ The checksum of /versions does not match the checksum provided by the server! So G bundle :install, :artifice => "compact_index_forbidden" - - expect(exitstatus).to eq(0) if exitstatus ensure home(".gemrc").rmtree end diff --git a/spec/bundler/install/gems/dependency_api_spec.rb b/spec/bundler/install/gems/dependency_api_spec.rb index da16ace767..765b5e5195 100644 --- a/spec/bundler/install/gems/dependency_api_spec.rb +++ b/spec/bundler/install/gems/dependency_api_spec.rb @@ -747,8 +747,6 @@ RSpec.describe "gemcutter's dependency API" do G bundle "install", :artifice => "endpoint_marshal_fail" - - expect(exitstatus).to eq(0) if exitstatus ensure home(".gemrc").rmtree end diff --git a/spec/bundler/install/gems/win32_spec.rb b/spec/bundler/install/gems/win32_spec.rb index 972a455bee..419b14ff0f 100644 --- a/spec/bundler/install/gems/win32_spec.rb +++ b/spec/bundler/install/gems/win32_spec.rb @@ -21,6 +21,5 @@ RSpec.describe "bundle install with win32-generated lockfile" do gem "rack" G - expect(exitstatus).to eq(0) if exitstatus end end diff --git a/spec/bundler/install/security_policy_spec.rb b/spec/bundler/install/security_policy_spec.rb index 07e4e12fa6..43c3069c4e 100644 --- a/spec/bundler/install/security_policy_spec.rb +++ b/spec/bundler/install/security_policy_spec.rb @@ -18,7 +18,6 @@ RSpec.describe "policies with unsigned gems" do it "will work after you try to deploy without a lock" do bundle "install --deployment", :raise_on_error => false bundle :install - expect(exitstatus).to eq(0) if exitstatus expect(the_bundle).to include_gems "rack 1.0", "signed_gem 1.0" end @@ -39,7 +38,6 @@ RSpec.describe "policies with unsigned gems" do it "will succeed with no policy" do bundle "install" - expect(exitstatus).to eq(0) if exitstatus end end @@ -64,13 +62,11 @@ RSpec.describe "policies with signed gems and no CA" do it "will succeed with Low Security setting, low security accepts self signed gem" do bundle "install --trust-policy=LowSecurity" - expect(exitstatus).to eq(0) if exitstatus expect(the_bundle).to include_gems "signed_gem 1.0" end it "will succeed with no policy" do bundle "install" - expect(exitstatus).to eq(0) if exitstatus expect(the_bundle).to include_gems "signed_gem 1.0" end end |