diff options
author | David RodrÃguez <deivid.rodriguez@riseup.net> | 2019-08-15 18:48:09 +0200 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2019-08-17 17:08:51 +0900 |
commit | 20c5154f0b79faf83c9c889f12da7da1ba9d6eb1 (patch) | |
tree | b12baf6407d0030b27e21118123e3cbe964fa5fa /spec/bundler | |
parent | 580e093fddc2c10ff4e6cd33bfa0a7bfab76395c (diff) | |
download | ruby-20c5154f0b79faf83c9c889f12da7da1ba9d6eb1.tar.gz |
[bundler/bundler] Only chdir when necessary
https://github.com/bundler/bundler/commit/07161ebc1a
Diffstat (limited to 'spec/bundler')
-rw-r--r-- | spec/bundler/quality_spec.rb | 30 |
1 files changed, 14 insertions, 16 deletions
diff --git a/spec/bundler/quality_spec.rb b/spec/bundler/quality_spec.rb index bcb9412d4d..40e1a113f0 100644 --- a/spec/bundler/quality_spec.rb +++ b/spec/bundler/quality_spec.rb @@ -225,24 +225,22 @@ RSpec.describe "The library itself" do end it "can still be built" do - Dir.chdir(root) do - if ruby_core? - spec = Gem::Specification.load(gemspec.to_s) - spec.bindir = "libexec" - File.open(root.join("bundler.gemspec").to_s, "w") {|f| f.write spec.to_ruby } - gem_command! :build, root.join("bundler.gemspec") - FileUtils.rm(root.join("bundler.gemspec")) - else - gem_command! :build, gemspec - end + if ruby_core? + spec = Gem::Specification.load(gemspec.to_s) + spec.bindir = "libexec" + File.open(root.join("bundler.gemspec").to_s, "w") {|f| f.write spec.to_ruby } + Dir.chdir(root) { gem_command! :build, root.join("bundler.gemspec") } + FileUtils.rm(root.join("bundler.gemspec")) + else + Dir.chdir(root) { gem_command! :build, gemspec } + end - bundler_path = root.join("bundler-#{Bundler::VERSION}.gem") + bundler_path = root.join("bundler-#{Bundler::VERSION}.gem") - begin - expect(err).to be_empty, "bundler should build as a gem without warnings, but\n#{err}" - ensure - bundler_path.rmtree - end + begin + expect(err).to be_empty, "bundler should build as a gem without warnings, but\n#{err}" + ensure + bundler_path.rmtree end end |