diff options
author | k0kubun <k0kubun@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-10-10 11:39:46 +0000 |
---|---|---|
committer | k0kubun <k0kubun@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-10-10 11:39:46 +0000 |
commit | 3f113219dfcc412247944fdbb75932cc3cc36891 (patch) | |
tree | 91f24ca7a2938398d9df7aba28d066793d5c2c5f /spec/ruby/core | |
parent | c7220bd3dea0a113b81f267cc3b656da7d7d7abb (diff) | |
download | ruby-3f113219dfcc412247944fdbb75932cc3cc36891.tar.gz |
spec: add comments to re-enable specs for MinGW [ci skip]
r64918 and r64988 should not be kept forever.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'spec/ruby/core')
-rw-r--r-- | spec/ruby/core/thread/terminate_spec.rb | 2 | ||||
-rw-r--r-- | spec/ruby/core/threadgroup/add_spec.rb | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/spec/ruby/core/thread/terminate_spec.rb b/spec/ruby/core/thread/terminate_spec.rb index e133d77d83..9815a7cee7 100644 --- a/spec/ruby/core/thread/terminate_spec.rb +++ b/spec/ruby/core/thread/terminate_spec.rb @@ -3,6 +3,8 @@ require_relative 'fixtures/classes' require_relative 'shared/exit' describe "Thread#terminate" do + # This spec randomly kills mspec worker like: https://ci.appveyor.com/project/ruby/ruby/builds/19390874/job/wv1bsm8skd4e1pxl + # TODO: Investigate the cause or at least print helpful logs, and remove this `platform_is_not` guard. platform_is_not :mingw do it_behaves_like :thread_exit, :terminate end diff --git a/spec/ruby/core/threadgroup/add_spec.rb b/spec/ruby/core/threadgroup/add_spec.rb index 267e0e9713..5d1354e65f 100644 --- a/spec/ruby/core/threadgroup/add_spec.rb +++ b/spec/ruby/core/threadgroup/add_spec.rb @@ -13,6 +13,8 @@ describe "ThreadGroup#add" do @thread.join end + # This spec randomly kills mspec worker like: https://ci.appveyor.com/project/ruby/ruby/build/9806/job/37tx2atojy96227m + # TODO: Investigate the cause or at least print helpful logs, and remove this `platform_is_not` guard. platform_is_not :mingw do it "adds the given thread to a group and returns self" do @thread.group.should_not == nil |