aboutsummaryrefslogtreecommitdiffstats
path: root/test/openssl
diff options
context:
space:
mode:
authorJeremy Evans <code@jeremyevans.net>2019-09-25 15:03:09 -0700
committerJeremy Evans <code@jeremyevans.net>2019-09-26 08:01:53 -0700
commit3959469f240edb6c1f43976bbb72a0ba9105a6b1 (patch)
tree00bec7d75bc80caf387b6ab22c8c3a30b9d6a565 /test/openssl
parent760893d2f85682a3c8c00be4b29dea0f6b2bb4f8 (diff)
downloadruby-3959469f240edb6c1f43976bbb72a0ba9105a6b1.tar.gz
Fix keyword argument separation issues in OpenSSL::SSL::SSLSocket#sys{read,write}_nonblock
It's unlikely anyone would actually hit these. The methods are private, you only hit this code path if calling these methods before performing the SSL connection, and there is already a verbose warning issued.
Diffstat (limited to 'test/openssl')
-rw-r--r--test/openssl/test_ssl.rb15
1 files changed, 15 insertions, 0 deletions
diff --git a/test/openssl/test_ssl.rb b/test/openssl/test_ssl.rb
index dad9a43779..940bc135ed 100644
--- a/test/openssl/test_ssl.rb
+++ b/test/openssl/test_ssl.rb
@@ -155,6 +155,21 @@ class OpenSSL::TestSSL < OpenSSL::SSLTestCase
}
end
+ def test_sysread_nonblock_and_syswrite_nonblock_keywords
+ start_server(ignore_listener_error: true) do |port|
+ sock = TCPSocket.new("127.0.0.1", port)
+ ssl = OpenSSL::SSL::SSLSocket.new(sock)
+
+ assert_warn ("") do
+ ssl.send(:syswrite_nonblock, "1", exception: false)
+ ssl.send(:sysread_nonblock, 1, exception: false) rescue nil
+ ssl.send(:sysread_nonblock, 1, String.new, exception: false) rescue nil
+ end
+ ensure
+ sock&.close
+ end
+ end
+
def test_sync_close
start_server { |port|
begin