diff options
author | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2019-10-25 01:16:05 +0900 |
---|---|---|
committer | Nobuyoshi Nakada <nobu@ruby-lang.org> | 2019-10-25 01:16:05 +0900 |
commit | b609bdeb5307e280137b4b2838af0fe4e4b46f1c (patch) | |
tree | 65434e9c844163b6f300b5eb256731e9bb0d2b67 /test/ruby | |
parent | 4b3e007e0778415e75ec2f0afcdc559eea43fdf8 (diff) | |
download | ruby-b609bdeb5307e280137b4b2838af0fe4e4b46f1c.tar.gz |
Define arguments forwarding as `ruby2_keywords` style
Get rid of these redundant and useless warnings.
```
$ ruby -e 'def bar(a) a; end; def foo(...) bar(...) end; foo({})'
-e:1: warning: The last argument is used as the keyword parameter
-e:1: warning: for `foo' defined here
-e:1: warning: The keyword argument is passed as the last hash parameter
-e:1: warning: for `bar' defined here
```
Diffstat (limited to 'test/ruby')
-rw-r--r-- | test/ruby/test_syntax.rb | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/test/ruby/test_syntax.rb b/test/ruby/test_syntax.rb index cbcdefb23b..5c2a9fc289 100644 --- a/test/ruby/test_syntax.rb +++ b/test/ruby/test_syntax.rb @@ -1527,13 +1527,23 @@ eom obj3.instance_eval('def foo(...) bar(...) end', __FILE__, __LINE__) [obj1, obj2, obj3].each do |obj| - assert_equal([[1, 2, 3], {k1: 4, k2: 5}], obj.foo(1, 2, 3, k1: 4, k2: 5) {|*x| x}) - assert_equal([[1, 2, 3], {k1: 4, k2: 5}], obj.foo(1, 2, 3, k1: 4, k2: 5)) + assert_warning('') { + assert_equal([[1, 2, 3], {k1: 4, k2: 5}], obj.foo(1, 2, 3, k1: 4, k2: 5) {|*x| x}) + } + assert_warning('') { + assert_equal([[1, 2, 3], {k1: 4, k2: 5}], obj.foo(1, 2, 3, k1: 4, k2: 5)) + } + warning = "warning: The last argument is used as the keyword parameter" + assert_warning(/\A\z|:(?!#{__LINE__+1})\d+: #{warning}/o) { + assert_equal([[], {}], obj.foo({}) {|*x| x}) + } + assert_warning(/\A\z|:(?!#{__LINE__+1})\d+: #{warning}/o) { + assert_equal([[], {}], obj.foo({})) + } assert_equal(-1, obj.:foo.arity) parameters = obj.:foo.parameters assert_equal(:rest, parameters.dig(0, 0)) - assert_equal(:keyrest, parameters.dig(1, 0)) - assert_equal(:block, parameters.dig(2, 0)) + assert_equal(:block, parameters.dig(1, 0)) end end |