aboutsummaryrefslogtreecommitdiffstats
path: root/test/rubygems/test_gem_ext_ext_conf_builder.rb
diff options
context:
space:
mode:
authorknu <knu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2013-06-25 13:28:57 +0000
committerknu <knu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2013-06-25 13:28:57 +0000
commit8cc31037224bca3e9b5c8e8f9ae206753a3822f8 (patch)
tree82ed31572cd801b8a5beae7f0577290f5f170034 /test/rubygems/test_gem_ext_ext_conf_builder.rb
parent7565d728b6f3910cf41ce106bf0b7bc2aef2bc77 (diff)
downloadruby-8cc31037224bca3e9b5c8e8f9ae206753a3822f8.tar.gz
* lib/rubygems/ext/builder.rb (Gem::Ext::Builder.make): Pass
DESTDIR via command line to override what's in MAKEFLAGS. This fixes an installation problem under a package building environment where DESTDIR is specified in the (parent) command line. [Fixes GH-327] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@41629 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'test/rubygems/test_gem_ext_ext_conf_builder.rb')
-rw-r--r--test/rubygems/test_gem_ext_ext_conf_builder.rb20
1 files changed, 7 insertions, 13 deletions
diff --git a/test/rubygems/test_gem_ext_ext_conf_builder.rb b/test/rubygems/test_gem_ext_ext_conf_builder.rb
index 734569583a..7c55626248 100644
--- a/test/rubygems/test_gem_ext_ext_conf_builder.rb
+++ b/test/rubygems/test_gem_ext_ext_conf_builder.rb
@@ -32,14 +32,8 @@ class TestGemExtExtConfBuilder < Gem::TestCase
assert_match(/^#{Gem.ruby} extconf.rb/, output[0])
assert_equal "creating Makefile\n", output[1]
- case RUBY_PLATFORM
- when /mswin/ then
- assert_equal "nmake", output[2]
- assert_equal "nmake install", output[4]
- else
- assert_equal "make", output[2]
- assert_equal "make install", output[4]
- end
+ assert_contains_make_command '', output[2]
+ assert_contains_make_command 'install', output[4]
end
def test_class_build_rbconfig_make_prog
@@ -56,8 +50,8 @@ class TestGemExtExtConfBuilder < Gem::TestCase
end
assert_equal "creating Makefile\n", output[1]
- assert_equal make_command, output[2]
- assert_equal "#{make_command} install", output[4]
+ assert_contains_make_command '', output[2]
+ assert_contains_make_command 'install', output[4]
ensure
RbConfig::CONFIG['configure_args'] = configure_args
end
@@ -80,7 +74,7 @@ class TestGemExtExtConfBuilder < Gem::TestCase
end
assert_equal "creating Makefile\n", output[1]
- assert_equal "anothermake", output[2]
+ assert_contains_make_command '', output[2]
ensure
RbConfig::CONFIG['configure_args'] = configure_args
ENV['make'] = env_make
@@ -132,8 +126,8 @@ checking for main\(\) in .*?nonexistent/m, error.message)
Gem::Ext::ExtConfBuilder.make @ext, output
end
- assert_equal make_command, output[0]
- assert_equal "#{make_command} install", output[2]
+ assert_contains_make_command '', output[0]
+ assert_contains_make_command 'install', output[2]
end
def test_class_make_no_Makefile