diff options
author | nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-11-07 11:38:08 +0000 |
---|---|---|
committer | nobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2018-11-07 11:38:08 +0000 |
commit | adb723bce7d50808943cc964763ea4b34b9a6712 (patch) | |
tree | 5d5da816abc22cbd40ffb076b774e8c104eb4d9a /test/rubygems | |
parent | 9e6183976551f44b5f3e10b06f88b28e9d13f0a1 (diff) | |
download | ruby-adb723bce7d50808943cc964763ea4b34b9a6712.tar.gz |
`+` sign in the path of ruby needs to be escaped
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65604 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'test/rubygems')
-rw-r--r-- | test/rubygems/test_gem_ext_ext_conf_builder.rb | 4 | ||||
-rw-r--r-- | test/rubygems/test_gem_ext_rake_builder.rb | 10 | ||||
-rw-r--r-- | test/rubygems/test_gem_installer.rb | 2 |
3 files changed, 8 insertions, 8 deletions
diff --git a/test/rubygems/test_gem_ext_ext_conf_builder.rb b/test/rubygems/test_gem_ext_ext_conf_builder.rb index 8d5135e309..bc87790183 100644 --- a/test/rubygems/test_gem_ext_ext_conf_builder.rb +++ b/test/rubygems/test_gem_ext_ext_conf_builder.rb @@ -35,7 +35,7 @@ class TestGemExtExtConfBuilder < Gem::TestCase end assert_match(/^current directory:/, output[0]) - assert_match(/^#{Gem.ruby}.* extconf.rb/, output[1]) + assert_match(/^#{Regexp.quote(Gem.ruby.shellescape)}.* extconf.rb/, output[1]) assert_equal "creating Makefile\n", output[2] assert_match(/^current directory:/, output[3]) assert_contains_make_command 'clean', output[4] @@ -109,7 +109,7 @@ class TestGemExtExtConfBuilder < Gem::TestCase assert_equal 'extconf failed, exit code 1', error.message - assert_match(/^#{Gem.ruby}.* extconf.rb/, output[1]) + assert_match(/^#{Regexp.quote(Gem.ruby.shellescape)}.* extconf.rb/, output[1]) assert_match(File.join(@dest_path, 'mkmf.log'), output[4]) assert_includes(output, "To see why this extension failed to compile, please check the mkmf.log which can be found here:\n") diff --git a/test/rubygems/test_gem_ext_rake_builder.rb b/test/rubygems/test_gem_ext_rake_builder.rb index 6b647293a8..b2dd7392c8 100644 --- a/test/rubygems/test_gem_ext_rake_builder.rb +++ b/test/rubygems/test_gem_ext_rake_builder.rb @@ -25,8 +25,8 @@ class TestGemExtRakeBuilder < Gem::TestCase output = output.join "\n" refute_match %r%^rake failed:%, output - assert_match %r%^#{Regexp.escape @@ruby} mkrf_conf\.rb%, output - assert_match %r%^#{Regexp.escape rake} RUBYARCHDIR\\=#{Regexp.escape @dest_path} RUBYLIBDIR\\=#{Regexp.escape @dest_path}%, output + assert_match %r%^#{Regexp.escape @@ruby.shellescape} mkrf_conf\.rb%, output + assert_match %r%^#{Regexp.escape rake.shellsplit.shelljoin} RUBYARCHDIR\\=#{Regexp.escape @dest_path.shellescape} RUBYLIBDIR\\=#{Regexp.escape @dest_path.shellescape}%, output end end @@ -46,8 +46,8 @@ class TestGemExtRakeBuilder < Gem::TestCase output = output.join "\n" refute_match %r%^rake failed:%, output - assert_match %r%^#{Regexp.escape @@ruby} mkrf_conf\.rb%, output - assert_match %r%^#{Regexp.escape rake} RUBYARCHDIR\\=#{Regexp.escape @dest_path} RUBYLIBDIR\\=#{Regexp.escape @dest_path}%, output + assert_match %r%^#{Regexp.escape @@ruby.shellescape} mkrf_conf\.rb%, output + assert_match %r%^#{Regexp.escape rake.shellsplit.shelljoin} RUBYARCHDIR\\=#{Regexp.escape @dest_path.shellescape} RUBYLIBDIR\\=#{Regexp.escape @dest_path.shellescape}%, output end end @@ -62,7 +62,7 @@ class TestGemExtRakeBuilder < Gem::TestCase output = output.join "\n" refute_match %r%^rake failed:%, output - assert_match %r%^#{Regexp.escape rake} RUBYARCHDIR\\=#{Regexp.escape @dest_path} RUBYLIBDIR\\=#{Regexp.escape @dest_path} test1 test2%, output + assert_match %r%^#{Regexp.escape rake.shellsplit.shelljoin} RUBYARCHDIR\\=#{Regexp.escape @dest_path.shellescape} RUBYLIBDIR\\=#{Regexp.escape @dest_path.shellescape} test1 test2%, output end end diff --git a/test/rubygems/test_gem_installer.rb b/test/rubygems/test_gem_installer.rb index 0ff4954d82..b8e4b1e2e5 100644 --- a/test/rubygems/test_gem_installer.rb +++ b/test/rubygems/test_gem_installer.rb @@ -692,7 +692,7 @@ gem 'other', version @installer.generate_bin - default_shebang = Gem.ruby + default_shebang = Gem.ruby.shellescape shebang_line = open("#{@gemhome}/bin/executable") { |f| f.readlines.first } assert_match(/\A#!/, shebang_line) assert_match(/#{default_shebang}/, shebang_line) |