aboutsummaryrefslogtreecommitdiffstats
path: root/thread_pthread.c
diff options
context:
space:
mode:
authornobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2014-06-11 08:37:44 +0000
committernobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2014-06-11 08:37:44 +0000
commite2b10b6d131425c395c5fe286ce6fd55d46f7c51 (patch)
tree4a8fb27c43ffbbfb6e5d9ceef71a048a162b3c48 /thread_pthread.c
parenta678de48c5d22bcceda459401bf74a9c7578ab7a (diff)
downloadruby-e2b10b6d131425c395c5fe286ce6fd55d46f7c51.tar.gz
thread_pthread.c: timer thread flag
* thread_pthread.c (timer_thread): add a flag to tell timer thread is created, since 0 may be a valid value as pthread_t. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46405 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'thread_pthread.c')
-rw-r--r--thread_pthread.c21
1 files changed, 13 insertions, 8 deletions
diff --git a/thread_pthread.c b/thread_pthread.c
index 848051afd1..11a1a2bf08 100644
--- a/thread_pthread.c
+++ b/thread_pthread.c
@@ -45,7 +45,11 @@ static void native_cond_wait(rb_nativethread_cond_t *cond, pthread_mutex_t *mute
static void native_cond_initialize(rb_nativethread_cond_t *cond, int flags);
static void native_cond_destroy(rb_nativethread_cond_t *cond);
static void rb_thread_wakeup_timer_thread_low(void);
-static pthread_t timer_thread_id;
+static struct {
+ pthread_t id;
+ int created;
+} timer_thread;
+#define TIMER_THREAD_CREATED_P() (timer_thread.created != 0)
#define RB_CONDATTR_CLOCK_MONOTONIC 1
@@ -1172,7 +1176,7 @@ ubf_select(void *ptr)
* In the other hands, we shouldn't call rb_thread_wakeup_timer_thread()
* if running on timer thread because it may make endless wakeups.
*/
- if (!pthread_equal(pthread_self(), timer_thread_id))
+ if (!pthread_equal(pthread_self(), timer_thread.id))
rb_thread_wakeup_timer_thread();
ubf_select_each(th);
}
@@ -1477,7 +1481,7 @@ thread_timer(void *p)
static void
rb_thread_create_timer_thread(void)
{
- if (!timer_thread_id) {
+ if (!timer_thread.created) {
int err;
#ifdef HAVE_PTHREAD_ATTR_INIT
pthread_attr_t attr;
@@ -1507,18 +1511,19 @@ rb_thread_create_timer_thread(void)
#endif /* USE_SLEEPY_TIMER_THREAD */
/* create timer thread */
- if (timer_thread_id) {
+ if (timer_thread.created) {
rb_bug("rb_thread_create_timer_thread: Timer thread was already created\n");
}
#ifdef HAVE_PTHREAD_ATTR_INIT
- err = pthread_create(&timer_thread_id, &attr, thread_timer, &GET_VM()->gvl);
+ err = pthread_create(&timer_thread.id, &attr, thread_timer, &GET_VM()->gvl);
#else
- err = pthread_create(&timer_thread_id, NULL, thread_timer, &GET_VM()->gvl);
+ err = pthread_create(&timer_thread.id, NULL, thread_timer, &GET_VM()->gvl);
#endif
if (err != 0) {
fprintf(stderr, "[FATAL] Failed to create timer thread: %s\n", strerror(err));
exit(EXIT_FAILURE);
}
+ timer_thread.created = 1;
#ifdef HAVE_PTHREAD_ATTR_INIT
pthread_attr_destroy(&attr);
#endif
@@ -1535,9 +1540,9 @@ native_stop_timer_thread(int close_anyway)
if (stopped) {
/* join */
rb_thread_wakeup_timer_thread();
- native_thread_join(timer_thread_id);
+ native_thread_join(timer_thread.id);
if (TT_DEBUG) fprintf(stderr, "joined timer thread\n");
- timer_thread_id = 0;
+ timer_thread.created = 0;
/* close communication pipe */
if (close_anyway) {