aboutsummaryrefslogtreecommitdiffstats
path: root/vm_insnhelper.c
diff options
context:
space:
mode:
authornobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-03-06 06:44:11 +0000
committernobu <nobu@b2dd03c8-39d4-4d8f-98ff-823fe69b080e>2017-03-06 06:44:11 +0000
commit034bbf1fddd2f5d5eff0712869e95580977efca8 (patch)
treea987bdab0c0b55f166117d9e5d87821a39d2c67a /vm_insnhelper.c
parent9d184819146bb7d24b30fc54ef206d9a592c9be4 (diff)
downloadruby-034bbf1fddd2f5d5eff0712869e95580977efca8.tar.gz
opt_eq_func refactor
* vm_insnhelper.c (opt_eq_func): method to dispatch is resolved by only the receiver's class, not including the argument class. even if basic operation is redefined, other class conditions never meet. optimize Float and non-Float case, delegate to rb_float_equal directly. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57785 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'vm_insnhelper.c')
-rw-r--r--vm_insnhelper.c41
1 files changed, 19 insertions, 22 deletions
diff --git a/vm_insnhelper.c b/vm_insnhelper.c
index 9e8ea9c9a8..f04d8365ab 100644
--- a/vm_insnhelper.c
+++ b/vm_insnhelper.c
@@ -1265,32 +1265,29 @@ inline
VALUE
opt_eq_func(VALUE recv, VALUE obj, CALL_INFO ci, CALL_CACHE cc)
{
- if (FIXNUM_2_P(recv, obj) &&
- BASIC_OP_UNREDEFINED_P(BOP_EQ, INTEGER_REDEFINED_OP_FLAG)) {
- return (recv == obj) ? Qtrue : Qfalse;
- }
- else if (FLONUM_2_P(recv, obj) &&
- BASIC_OP_UNREDEFINED_P(BOP_EQ, FLOAT_REDEFINED_OP_FLAG)) {
- return (recv == obj) ? Qtrue : Qfalse;
- }
- else if (!SPECIAL_CONST_P(recv) && !SPECIAL_CONST_P(obj)) {
- if (RBASIC_CLASS(recv) == rb_cFloat &&
- RBASIC_CLASS(obj) == rb_cFloat &&
- BASIC_OP_UNREDEFINED_P(BOP_EQ, FLOAT_REDEFINED_OP_FLAG)) {
- double a = RFLOAT_VALUE(recv);
- double b = RFLOAT_VALUE(obj);
-
- if (isnan(a) || isnan(b)) {
- return Qfalse;
- }
- return (a == b) ? Qtrue : Qfalse;
+#define BUILTIN_CLASS_P(x, k) (!SPECIAL_CONST_P(x) && RBASIC_CLASS(x) == k)
+#define EQ_UNREDEFINED_P(t) BASIC_OP_UNREDEFINED_P(BOP_EQ, t##_REDEFINED_OP_FLAG)
+ if (FIXNUM_2_P(recv, obj)) {
+ if (EQ_UNREDEFINED_P(INTEGER)) {
+ return (recv == obj) ? Qtrue : Qfalse;
+ }
+ }
+ else if (FLONUM_2_P(recv, obj)) {
+ if (EQ_UNREDEFINED_P(FLOAT)) {
+ return (recv == obj) ? Qtrue : Qfalse;
}
- else if (RBASIC_CLASS(recv) == rb_cString &&
- RBASIC_CLASS(obj) == rb_cString &&
- BASIC_OP_UNREDEFINED_P(BOP_EQ, STRING_REDEFINED_OP_FLAG)) {
+ }
+ else if (BUILTIN_CLASS_P(recv, rb_cFloat)) {
+ if (EQ_UNREDEFINED_P(FLOAT)) {
+ return rb_float_equal(recv, obj);
+ }
+ }
+ else if (BUILTIN_CLASS_P(recv, rb_cString)) {
+ if (EQ_UNREDEFINED_P(STRING)) {
return rb_str_equal(recv, obj);
}
}
+#undef EQ_UNREDEFINED_P
{
vm_search_method(ci, cc, recv);