diff options
-rw-r--r-- | ChangeLog | 7 | ||||
-rw-r--r-- | bignum.c | 7 | ||||
-rw-r--r-- | ext/bigdecimal/bigdecimal.c | 2 |
3 files changed, 14 insertions, 2 deletions
@@ -1,3 +1,10 @@ +Tue Feb 11 23:42:27 2014 Tanaka Akira <akr@fsij.org> + + * bignum.c (rb_big_cmp): Specialize a comparison to zero. + + * ext/bigdecimal/bigdecimal.c (is_negative): Use rb_big_cmp instead of + RBIGNUM_NEGATIVE_P. + Tue Feb 11 22:59:10 2014 Tanaka Akira <akr@fsij.org> * ext/openssl/ossl_bn.c (ossl_bn_initialize): Use rb_integer_pack. @@ -5395,7 +5395,12 @@ rb_big_cmp(VALUE x, VALUE y) { int cmp; - if (FIXNUM_P(y)) { + if (y == INT2FIX(0)) { + if (BIGZEROP(x)) return INT2FIX(0); + if (RBIGNUM_NEGATIVE_P(x)) return INT2FIX(-1); + return INT2FIX(1); + } + else if (FIXNUM_P(y)) { y = rb_int2big(FIX2LONG(y)); } else if (RB_BIGNUM_TYPE_P(y)) { diff --git a/ext/bigdecimal/bigdecimal.c b/ext/bigdecimal/bigdecimal.c index 206e5d3f5a..f426a45cef 100644 --- a/ext/bigdecimal/bigdecimal.c +++ b/ext/bigdecimal/bigdecimal.c @@ -2095,7 +2095,7 @@ is_negative(VALUE x) return FIX2LONG(x) < 0; } else if (RB_TYPE_P(x, T_BIGNUM)) { - return RBIGNUM_NEGATIVE_P(x); + return FIX2INT(rb_big_cmp(x, INT2FIX(0))) < 0; } else if (RB_TYPE_P(x, T_FLOAT)) { return RFLOAT_VALUE(x) < 0.0; |