diff options
-rw-r--r-- | ChangeLog | 5 | ||||
-rw-r--r-- | string.c | 2 | ||||
-rw-r--r-- | test/ruby/test_string.rb | 4 |
3 files changed, 10 insertions, 1 deletions
@@ -1,3 +1,8 @@ +Wed Feb 25 02:28:51 2009 Nobuyoshi Nakada <nobu@ruby-lang.org> + + * string.c (rb_str_chomp_bang): coderange may change. + [ruby-core:22414] + Wed Feb 25 02:17:30 2009 Nobuyoshi Nakada <nobu@ruby-lang.org> * string.c (rb_str_delete_bang): should recalculate coderange. @@ -6056,7 +6056,7 @@ rb_str_chomp_bang(int argc, VALUE *argv, VALUE str) memcmp(RSTRING_PTR(rs), pp, rslen) == 0)) { if (rb_enc_left_char_head(p, pp, e, enc) != pp) return Qnil; - str_modify_keep_cr(str); + rb_str_modify(str); STR_SET_LEN(str, RSTRING_LEN(str) - rslen); RSTRING_PTR(str)[RSTRING_LEN(str)] = '\0'; return str; diff --git a/test/ruby/test_string.rb b/test/ruby/test_string.rb index a995087bbc..bf3861e74d 100644 --- a/test/ruby/test_string.rb +++ b/test/ruby/test_string.rb @@ -339,6 +339,8 @@ class TestString < Test::Unit::TestCase assert_equal(S("hello"), S("hello").chomp) assert_equal(S("hello"), S("hello!").chomp) $/ = save + + assert_equal(S("a").hash, S("a\u0101").chomp(S("\u0101")).hash, '[ruby-core:22414]') end def test_chomp! @@ -393,6 +395,8 @@ class TestString < Test::Unit::TestCase s = "foo\r" s.chomp!("") assert_equal("foo\r", s) + + assert_equal(S("a").hash, S("a\u0101").chomp!(S("\u0101")).hash, '[ruby-core:22414]') end def test_chop |